legacy/signing: Don't force nJoinSplit to be 0 for prev_tx in overwintered. This was dead code until we started validating prevout amounts.

4 years ago · e6745bce43
parent 386be6ff09
commit e6745bce43
1 changed files with 1 additions and 2 deletions
--- a/legacy/firmware/transaction.c
+++ b/legacy/firmware/transaction.c
@ -711,8 +711,7 @@ uint32_t tx_serialize_footer_hash(TxStruct *tx) {
 #if !BITCOIN_ONLY
  if (tx->overwintered) {
    hasher_Update(&(tx->hasher), (const uint8_t *)&(tx->expiry), 4);
-    hasher_Update(&(tx->hasher), (const uint8_t *)"\x00", 1);  // nJoinSplit
-    return 9;
+    return 8;
  }
  if (tx->is_decred) {
    hasher_Update(&(tx->hasher), (const uint8_t *)&(tx->expiry), 4);