From e6745bce438506a9f8c0e7e4212e021d4b12c2e5 Mon Sep 17 00:00:00 2001 From: Andrew Kozlik Date: Mon, 30 Mar 2020 11:13:34 +0200 Subject: [PATCH] legacy/signing: Don't force nJoinSplit to be 0 for prev_tx in overwintered. This was dead code until we started validating prevout amounts. --- legacy/firmware/transaction.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/legacy/firmware/transaction.c b/legacy/firmware/transaction.c index 28866603f..e5b68e0e4 100644 --- a/legacy/firmware/transaction.c +++ b/legacy/firmware/transaction.c @@ -711,8 +711,7 @@ uint32_t tx_serialize_footer_hash(TxStruct *tx) { #if !BITCOIN_ONLY if (tx->overwintered) { hasher_Update(&(tx->hasher), (const uint8_t *)&(tx->expiry), 4); - hasher_Update(&(tx->hasher), (const uint8_t *)"\x00", 1); // nJoinSplit - return 9; + return 8; } if (tx->is_decred) { hasher_Update(&(tx->hasher), (const uint8_t *)&(tx->expiry), 4);