arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-16 19:38:09 +00:00
Code Issues Releases Wiki Activity

fix out-of-bounds read (for debug_link)

Browse Source 
Pinmatrix should always be null-terminated for debug-link.
The memset overwrote the terminating nul character.
This commit is contained in:
Jochen Hoenicke 2018-03-23 17:19:30 +01:00 committed by Pavol Rusnak
parent c4e1c5953e
commit a7158f39a5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/pinmatrix.c
View File

@ -69,7 +69,7 @@ void pinmatrix_done(char *pin)
}
i++;
}
memset(pinmatrix_perm, 'X', sizeof(pinmatrix_perm));
memset(pinmatrix_perm, 'X', sizeof(pinmatrix_perm) - 1);
}
#if DEBUG_LINK