From a7158f39a5cd154856c90288ea8e8d7a13368852 Mon Sep 17 00:00:00 2001 From: Jochen Hoenicke Date: Fri, 23 Mar 2018 17:19:30 +0100 Subject: [PATCH] fix out-of-bounds read (for debug_link) Pinmatrix should always be null-terminated for debug-link. The memset overwrote the terminating nul character. --- firmware/pinmatrix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firmware/pinmatrix.c b/firmware/pinmatrix.c index c3a5aac99c..e2234292a8 100644 --- a/firmware/pinmatrix.c +++ b/firmware/pinmatrix.c @@ -69,7 +69,7 @@ void pinmatrix_done(char *pin) } i++; } - memset(pinmatrix_perm, 'X', sizeof(pinmatrix_perm)); + memset(pinmatrix_perm, 'X', sizeof(pinmatrix_perm) - 1); } #if DEBUG_LINK