arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-11-29 10:58:21 +00:00
Code Issues Releases Wiki Activity

xmr: protob protocol improvements (#192)

Browse Source 
- uses protobuff messages only for the transaction construction data - forward compatible. Not stable on Monero side, serialization format of the cryptonote serialization could be changed in the future (new fields), CN serialization does not support versioning, thus it is not forward compatible.
- MoneroTransactionDestinationEntry, MoneroTransactionSourceEntry have to be defined in the root level as they are used in various protocol messages
This commit is contained in:
Dušan Klinec 2018-08-15 11:39:06 +02:00 committed by Pavol Rusnak
parent 3765399d9d
commit 1ef050fb15
1 changed files with 53 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
protob/messages-monero.proto
View File

@ -47,6 +47,23 @@ message MoneroWatchKey {
optional bytes address = 2; optional bytes address = 2;
} }
/**
* Structure representing Monero transaction destination entry
*/
message MoneroTransactionDestinationEntry {
optional uint64 amount = 1;
optional MoneroAccountPublicAddress addr = 2;
optional bool is_subaddress = 3;
/**
* Structure representing Monero public address
*/
message MoneroAccountPublicAddress {
optional bytes spend_public_key = 1;
optional bytes view_public_key = 2;
}
}
/** /**
* Request: Sub request of MoneroTransactionSign. Initializes transaction signing. * Request: Sub request of MoneroTransactionSign. Initializes transaction signing.
* @start * @start
@ -75,21 +92,6 @@ message MoneroTransactionInitRequest {
optional bytes exp_tx_prefix_hash = 12; optional bytes exp_tx_prefix_hash = 12;
repeated bytes use_tx_keys = 13; repeated bytes use_tx_keys = 13;
optional bool is_bulletproof = 14; optional bool is_bulletproof = 14;
/**
* Structure representing Monero transaction destination entry
*/
message MoneroTransactionDestinationEntry {
optional uint64 amount = 1;
optional MoneroAccountPublicAddress addr = 2;
optional bool is_subaddress = 3;
/**
* Structure representing Monero public address
*/
message MoneroAccountPublicAddress {
optional bytes spend_public_key = 1;
optional bytes view_public_key = 2;
}
}
} }
} }
@ -106,13 +108,45 @@ message MoneroTransactionInitAck {
optional bool many_outputs = 6; optional bool many_outputs = 6;
} }
/**
* Structure representing Monero transaction source entry, UTXO
*/
message MoneroTransactionSourceEntry {
repeated MoneroOutputEntry outputs = 1;
optional uint64 real_output = 2;
optional bytes real_out_tx_key = 3;
repeated bytes real_out_additional_tx_keys = 4;
optional uint64 real_output_in_tx_index = 5;
optional uint64 amount = 6;
optional bool rct = 7;
optional bytes mask = 8;
optional MoneroMultisigKLRki multisig_kLRki = 9;
message MoneroRctKey {
optional bytes dest = 1;
optional bytes mask = 2;
}
message MoneroOutputEntry {
optional uint64 idx = 1;
optional MoneroRctKey key = 2;
}
message MoneroMultisigKLRki {
optional bytes K = 1;
optional bytes L = 2;
optional bytes R = 3;
optional bytes ki = 4;
}
}
/** /**
* Request: Sub request of MoneroTransactionSign. Sends one UTXO to device * Request: Sub request of MoneroTransactionSign. Sends one UTXO to device
* @next MoneroTransactionSetInputAck * @next MoneroTransactionSetInputAck
*/ */
message MoneroTransactionSetInputRequest { message MoneroTransactionSetInputRequest {
optional uint32 version = 1; optional uint32 version = 1;
optional bytes src_entr = 2; // xmrtypes.TxSourceEntry optional MoneroTransactionSourceEntry src_entr = 2;
} }
/** /**
@ -148,7 +182,7 @@ message MoneroTransactionInputsPermutationAck {
* @next MoneroTransactionInputViniAck * @next MoneroTransactionInputViniAck
*/ */
message MoneroTransactionInputViniRequest { message MoneroTransactionInputViniRequest {
optional bytes src_entr = 1; // xmrtypes.TxSourceEntry optional MoneroTransactionSourceEntry src_entr = 1;
optional bytes vini = 2; // xmrtypes.TxinToKey optional bytes vini = 2; // xmrtypes.TxinToKey
optional bytes vini_hmac = 3; optional bytes vini_hmac = 3;
optional bytes pseudo_out = 4; optional bytes pseudo_out = 4;
@ -167,7 +201,7 @@ message MoneroTransactionInputViniAck {
* @next MoneroTransactionSetOutputAck * @next MoneroTransactionSetOutputAck
*/ */
message MoneroTransactionSetOutputRequest { message MoneroTransactionSetOutputRequest {
optional bytes dst_entr = 1; // xmrtypes.TxDestinationEntry optional MoneroTransactionDestinationEntry dst_entr = 1;
optional bytes dst_entr_hmac = 2; optional bytes dst_entr_hmac = 2;
} }
@ -228,7 +262,7 @@ message MoneroTransactionMlsagDoneAck {
* @next MoneroTransactionSignInputAck * @next MoneroTransactionSignInputAck
*/ */
message MoneroTransactionSignInputRequest { message MoneroTransactionSignInputRequest {
optional bytes src_entr = 1; // xmrtypes.TxSourceEntry optional MoneroTransactionSourceEntry src_entr = 1;
optional bytes vini = 2; // xmrtypes.TxinToKey optional bytes vini = 2; // xmrtypes.TxinToKey
optional bytes vini_hmac = 3; optional bytes vini_hmac = 3;
optional bytes pseudo_out = 4; optional bytes pseudo_out = 4;