jsteube
|
7858f37800
|
Fix for CID 1402403
|
2017-02-15 13:27:33 +01:00 |
|
jsteube
|
e47932262d
|
Fix uint datatype (should be u32)
|
2017-02-15 13:26:02 +01:00 |
|
philsmd
|
6eaa7e3741
|
tainted string fix: check some lower/upper bounds of the strings
|
2017-02-15 13:19:53 +01:00 |
|
philsmd
|
98129da7dc
|
add dummy check around hashcat_get_status () within inner2_loop to make coverity happy
|
2017-02-15 12:57:18 +01:00 |
|
philsmd
|
fe33957303
|
rule engine: prevent integer underflow and dead code
|
2017-02-15 12:41:32 +01:00 |
|
jsteube
|
b4bfade4ec
|
Merge branch 'master' of https://github.com/hashcat/hashcat
|
2017-02-15 12:36:09 +01:00 |
|
jsteube
|
b381b38fd8
|
Fix CID 1402374
|
2017-02-15 12:36:03 +01:00 |
|
philsmd
|
1a0b1cd144
|
cpu MD5: use smaller than (<) instead of != to make coverity happy
|
2017-02-15 12:11:18 +01:00 |
|
jsteube
|
8b28940630
|
Merge branch 'master' of https://github.com/hashcat/hashcat
|
2017-02-15 12:09:30 +01:00 |
|
jsteube
|
104958af2d
|
Fix CID 1402413
|
2017-02-15 12:09:14 +01:00 |
|
philsmd
|
12517f1b7a
|
typo: don't add URI_prefix_len and URI_suffix_len twice
|
2017-02-15 11:50:35 +01:00 |
|
philsmd
|
02480f906a
|
prevent buffer overflow in case of OPTS_TYPE_ST_ADD80 and/or OPTS_TYPE_ST_ADD01
|
2017-02-15 11:33:52 +01:00 |
|
philsmd
|
0993f2e748
|
fixed maximum salt_len for pbkdf2 buffers
|
2017-02-14 22:05:47 +01:00 |
|
philsmd
|
54915e4d7b
|
minor: do not use UINT_MAX as upper bound for the salt_len
|
2017-02-14 21:54:49 +01:00 |
|
philsmd
|
f351461ecd
|
max esalt_buf for sip fixed: we also need to append 0x80
|
2017-02-14 21:45:18 +01:00 |
|
jsteube
|
be3ce44f75
|
Fix CID 1402444 (#1 of 1): Out-of-bounds read
|
2017-02-14 21:40:11 +01:00 |
|
philsmd
|
056d1f3da4
|
minor: use 2 distinct return value to avoid dead code detections
|
2017-02-14 21:24:45 +01:00 |
|
jsteube
|
f61788eac1
|
Merge branch 'master' of https://github.com/hashcat/hashcat
|
2017-02-14 21:22:04 +01:00 |
|
jsteube
|
0642639b81
|
CID 1402417 (#1 of 1): Division or modulo by float zero
|
2017-02-14 21:21:24 +01:00 |
|
philsmd
|
1f88ae42ef
|
dead code: hash_len is always > 0 at this location
|
2017-02-14 21:09:04 +01:00 |
|
jsteube
|
ed772a02a4
|
Check for at least one active OpenCL device before running weak-hash-check
|
2017-02-14 21:05:44 +01:00 |
|
philsmd
|
9ed93fcce9
|
dead code: here we do not need to check for NULL
|
2017-02-14 21:01:52 +01:00 |
|
jsteube
|
6bcfca26b3
|
Fix CID 1402873: Dereference before null check
|
2017-02-14 20:53:42 +01:00 |
|
philsmd
|
f535eb2bd0
|
always check the input for NULL before the strtok_r () calls
|
2017-02-14 20:46:03 +01:00 |
|
Jens Steube
|
f9bbd42b4a
|
Merge pull request #1092 from philsmd/master
fix our usage of strtok_r (), it was not 100% correct
|
2017-02-14 20:12:18 +01:00 |
|
philsmd
|
12047861c5
|
also double-check input/output of strtok_r ()
|
2017-02-14 20:07:49 +01:00 |
|
jsteube
|
4b3d39623c
|
Restore: Add some checks on the rd->cwd variable in restore case
|
2017-02-14 20:05:44 +01:00 |
|
jsteube
|
b2dbd22979
|
Moved datatype from double to u32 in autotune.c as this makes no difference
|
2017-02-14 19:51:49 +01:00 |
|
philsmd
|
a82f6fb77c
|
our usage of strtok_r () was not totally correct (but almost)
|
2017-02-14 19:48:07 +01:00 |
|
philsmd
|
e5ecbb9a59
|
minor: within parse_and_store_salt () do the initialization of the buffer at the very start
|
2017-02-14 19:30:36 +01:00 |
|
Jens Steube
|
33da74f6db
|
Merge pull request #1090 from philsmd/pr/hwmon_step_fix
minor: the step value should never be zero
|
2017-02-14 19:25:46 +01:00 |
|
philsmd
|
5ea1bd2a99
|
minor: the step value should never be zero
|
2017-02-14 19:22:51 +01:00 |
|
philsmd
|
05f8abdbe7
|
minor: useless code (since we removed the swaps)
|
2017-02-14 19:17:45 +01:00 |
|
philsmd
|
f87c65d081
|
minor: check return value of hc_stat () and use fclose () in case of error
|
2017-02-14 19:12:24 +01:00 |
|
philsmd
|
7818712090
|
minor: check for return value of sscanf () within the zip2 parse function
|
2017-02-14 18:58:25 +01:00 |
|
philsmd
|
9efc429928
|
dead code: in office parse functions
|
2017-02-14 18:49:35 +01:00 |
|
philsmd
|
94a37157c1
|
dead code: both hashes_avail and hash_len can't be 0 here
|
2017-02-14 18:33:53 +01:00 |
|
philsmd
|
4eadbf221e
|
dead code: already implied length within the android fde parsing function
|
2017-02-14 18:25:20 +01:00 |
|
philsmd
|
8fa361dffa
|
dead code: already implied length within the android fde parsing function
|
2017-02-14 18:22:46 +01:00 |
|
jsteube
|
d069c980d0
|
Testfix for CID 1402439 (#1 of 1): Out-of-bounds read
|
2017-02-14 18:07:33 +01:00 |
|
jsteube
|
958ca90132
|
Test failed to workaround coverity false-positive
|
2017-02-14 17:59:23 +01:00 |
|
Jens Steube
|
b682091155
|
Merge pull request #1082 from philsmd/master
we always need to check for NULL after strchr ()
|
2017-02-14 17:55:37 +01:00 |
|
jsteube
|
231592101e
|
Test commit to workaround coverity false-positive
|
2017-02-14 17:54:36 +01:00 |
|
philsmd
|
d366a93bb3
|
we always need to check for NULL after strchr ()
|
2017-02-14 17:54:18 +01:00 |
|
philsmd
|
49ba6cb05d
|
-m 13100 = Kerberos 5 TGS-REP: parser failed to correctly verify the hash
|
2017-02-14 17:45:05 +01:00 |
|
philsmd
|
6915bfad8b
|
keyfiles: for VeraCrypt/TrueCrypt keyfiles we need to free the memory in case of errors
|
2017-02-14 17:32:39 +01:00 |
|
philsmd
|
23368c7304
|
fix: added additional fclose () whenever an hash parsing error occurs
|
2017-02-14 17:22:52 +01:00 |
|
jsteube
|
906bcf52f9
|
CID 1402488 (#1 of 1): Resource leak
|
2017-02-14 17:18:57 +01:00 |
|
jsteube
|
7f3d107129
|
Fixed pointer to local outside scope in case -j or -k is used
|
2017-02-14 17:13:36 +01:00 |
|
Jens Steube
|
a3efaa219c
|
Merge pull request #1078 from philsmd/master
if fstat () fails we shouldn't forget to close the file
|
2017-02-14 17:08:25 +01:00 |
|
jsteube
|
6eb4747dce
|
Merge branch 'master' of https://github.com/hashcat/hashcat
|
2017-02-14 17:08:10 +01:00 |
|
jsteube
|
cc223123e9
|
OpenCL Kernel: Refactored read_kernel_binary to load only a single kernel for a single device
|
2017-02-14 17:08:08 +01:00 |
|
philsmd
|
d20079bfe1
|
if fstat () fails we shouldn't forget to close the file
|
2017-02-14 17:05:35 +01:00 |
|
Jens Steube
|
bcb05697c0
|
Merge pull request #1077 from philsmd/master
if fstat () fails we shouldn't forget to close the file
|
2017-02-14 17:04:40 +01:00 |
|
philsmd
|
aed01460f2
|
if fstat () fails we shouldn't forget to close the file
|
2017-02-14 17:02:52 +01:00 |
|
jsteube
|
5a2e7f2a3a
|
CID 1402490 (#1 of 1): Resource leak
|
2017-02-14 17:02:08 +01:00 |
|
jsteube
|
dcdafdbc08
|
CID 1402467 (#1 of 1): Resource leak
|
2017-02-14 17:01:13 +01:00 |
|
jsteube
|
b2c9172f65
|
Fix missing free() in pidfile.c
|
2017-02-14 16:58:18 +01:00 |
|
jsteube
|
20ab1af2b3
|
OpenCL Kernel: Move kernel binary buffer from heap to stack memory
|
2017-02-14 16:56:41 +01:00 |
|
philsmd
|
f2b370e470
|
file locking: for windows we need to just return 0 (otherwise compiler complains)
|
2017-02-14 16:53:01 +01:00 |
|
Jens Steube
|
7209b0562a
|
Merge pull request #1075 from philsmd/master
mp: memory checks added to avoid leaks
|
2017-02-14 16:51:29 +01:00 |
|
jsteube
|
302f528796
|
OpenCL Kernel: Move kernel binary buffer from heap to stack memory
|
2017-02-14 16:51:03 +01:00 |
|
philsmd
|
437289c41e
|
mp: memory checks added to avoid leaks
|
2017-02-14 16:46:41 +01:00 |
|
Jens Steube
|
259f8f6bb2
|
Merge pull request #1074 from philsmd/master
outfile check: also out_info variable needs to be freed
|
2017-02-14 16:41:58 +01:00 |
|
jsteube
|
2824192cc5
|
Fix several memory leaks in pidfile handling in case a hashcat instance is already running
|
2017-02-14 16:40:08 +01:00 |
|
philsmd
|
c16145dffd
|
outfile check: also out_info variable needs to be freed
|
2017-02-14 16:27:39 +01:00 |
|
jsteube
|
c859cff25c
|
File Reads: Fixed memory leak in case outfile or hashfile was not accessible
|
2017-02-14 16:25:38 +01:00 |
|
jsteube
|
cb58c84754
|
Merge branch 'master' of https://github.com/hashcat/hashcat
|
2017-02-14 16:12:26 +01:00 |
|
jsteube
|
671f9a7eb7
|
Fix hc_path_create(), first close the file descriptor before unlinking the file itself
|
2017-02-14 16:12:18 +01:00 |
|
philsmd
|
1b41e6aba3
|
rule engine: 2 more possibly memory leaks (see previous commits)
|
2017-02-14 16:07:33 +01:00 |
|
Jens Steube
|
ddace83b41
|
Merge pull request #1072 from philsmd/master
-m 11400 = SIP digest authentication (MD5): added bound checks in parser
|
2017-02-14 16:01:51 +01:00 |
|
jsteube
|
9b1ce502b8
|
Hardware Monitor: Fixed several memory leaks in case hash-file writing (in case of --remove) failed
|
2017-02-14 16:00:10 +01:00 |
|
philsmd
|
553eddad49
|
-m 11400 = SIP digest authentication (MD5): added bound checks in parser
|
2017-02-14 15:58:44 +01:00 |
|
jsteube
|
a9b0f1a559
|
Wordlists: Fixed memory leak in case access a file in a wordlist folder fails
|
2017-02-14 15:47:41 +01:00 |
|
jsteube
|
1fc24cbcd3
|
Mask Increment: Fixed memory leak in case mask_append() fails
|
2017-02-14 15:38:57 +01:00 |
|
philsmd
|
67a8584f7c
|
precompute_salt_md5: don't allow a salt_len > 64
|
2017-02-14 15:27:31 +01:00 |
|
jsteube
|
0531d41c05
|
Merge branch 'master' of https://github.com/hashcat/hashcat
|
2017-02-14 15:19:39 +01:00 |
|
jsteube
|
53d6808794
|
Fixed pointer to local outside scope when using not specifying --markov-hcstat
|
2017-02-14 15:19:05 +01:00 |
|
philsmd
|
c440dec867
|
file locking: check return value of fcntl ()
|
2017-02-14 15:15:50 +01:00 |
|
jsteube
|
cdfabe333f
|
Fixed pointer to local outside scope when using -j or -k
|
2017-02-14 15:09:01 +01:00 |
|
philsmd
|
d92f8b1d82
|
memory: we should free this memory in case of error in folder.c
|
2017-02-14 14:45:27 +01:00 |
|
jsteube
|
dc2ecc9dae
|
Fixed pointer to local outside scope when using -j or -k
|
2017-02-14 14:27:08 +01:00 |
|
philsmd
|
b285c04a21
|
added additional memory leak checks within the rule engine
|
2017-02-14 14:21:27 +01:00 |
|
jsteube
|
291c1bcdd2
|
Dispatcher: Fixed several memory leaks when an OpenCL error occurs
|
2017-02-14 14:02:18 +01:00 |
|
philsmd
|
c1b89fb2ac
|
added return code check whenever fstat () was called
|
2017-02-14 13:57:24 +01:00 |
|
philsmd
|
d1e3d64440
|
outfile check: out_files variable should be freed (also) in case of an error
|
2017-02-14 13:44:31 +01:00 |
|
jsteube
|
d48c1c6291
|
Workaround for CID 1402437 (#1 of 1): Out-of-bounds write
|
2017-02-14 13:28:25 +01:00 |
|
philsmd
|
5612e721b8
|
minor: use memset () before memcpy () in cpu MD5 function
|
2017-02-14 13:21:11 +01:00 |
|
jsteube
|
521c819842
|
CPU Affinity: Fixed memory leak when invalid cpu Id was specified
|
2017-02-14 12:42:22 +01:00 |
|
jsteube
|
ce5117631e
|
Hardware Monitor: Fixed several memory leaks when no AMDGPU-Pro hardware monitor sensor is found
|
2017-02-14 12:30:15 +01:00 |
|
philsmd
|
5594a6703c
|
mem problem in OpenCL device management: free () the platforms string
|
2017-02-14 12:17:33 +01:00 |
|
philsmd
|
f1900686f5
|
OpenCL kernel run: minor copy-paste error removed
|
2017-02-14 12:03:45 +01:00 |
|
jsteube
|
9b14a3f853
|
Hardware Monitor: Fixed several memory leaks when no hardware monitor sensor is found
|
2017-02-14 12:02:45 +01:00 |
|
philsmd
|
6ef802a148
|
OpenCL platforms/devices: Fixed several memory leaks when a platform/device could not be used/initialized
|
2017-02-14 11:52:53 +01:00 |
|
jsteube
|
15f9a3ad83
|
Hardware Monitor: Fixed several memory leaks when no hardware monitor sensor is found
|
2017-02-14 11:48:18 +01:00 |
|
Jens Steube
|
0280aff571
|
Merge pull request #1060 from philsmd/pr/initialize_hc_stat_t
fix: initialize the hc_stat_t structs before using/modifying them
|
2017-02-14 11:25:41 +01:00 |
|
jsteube
|
8ba031c60c
|
Merge branch 'master' of https://github.com/hashcat/hashcat
|
2017-02-14 11:18:22 +01:00 |
|
philsmd
|
5f6ba4bf4b
|
fix: initialize the hc_stat_t structs before using/modifying them
|
2017-02-14 11:17:19 +01:00 |
|
jsteube
|
dc4f96f42e
|
Fixed string not null terminated when reading maskfiles
|
2017-02-14 11:14:32 +01:00 |
|
philsmd
|
0771a8e36a
|
fix: we should initialize the aes_key in seven_zip_hook_func ()
|
2017-02-14 11:10:33 +01:00 |
|