Workaround for CID 1402437 (#1 of 1): Out-of-bounds write

7 years ago · d48c1c6291
parent 1353a727b8
commit d48c1c6291
1 changed files with 4 additions and 6 deletions
--- a/src/cpu_crc32.c
+++ b/src/cpu_crc32.c
@ -116,12 +116,10 @@ int cpu_crc32 (hashcat_ctx_t *hashcat_ctx, const char *filename, u8 keytab[64])
  {
    crc = crc32tab[(crc ^ buf[fpos]) & 0xff] ^ (crc >> 8);

-    keytab[kpos++] += (crc >> 24) & 0xff;
-    keytab[kpos++] += (crc >> 16) & 0xff;
-    keytab[kpos++] += (crc >>  8) & 0xff;
-    keytab[kpos++] += (crc >>  0) & 0xff;
-
-    if (kpos >= 64) kpos = 0;
+    keytab[kpos++] += (crc >> 24) & 0xff; if (kpos >= 64) kpos = 0;
+    keytab[kpos++] += (crc >> 16) & 0xff; if (kpos >= 64) kpos = 0;
+    keytab[kpos++] += (crc >>  8) & 0xff; if (kpos >= 64) kpos = 0;
+    keytab[kpos++] += (crc >>  0) & 0xff; if (kpos >= 64) kpos = 0;
  }

  hcfree (buf);