prevent buffer overflow in case of OPTS_TYPE_ST_ADD80 and/or OPTS_TYPE_ST_ADD01

8 years ago · 02480f906a
parent 8717672d00
commit 02480f906a
1 changed files with 4 additions and 0 deletions
--- a/src/interface.c
+++ b/src/interface.c
@ -2109,11 +2109,15 @@ static u32 parse_and_store_salt (u8 *out, u8 *in, u32 salt_len, MAYBE_UNUSED con

  if (hashconfig->opts_type & OPTS_TYPE_ST_ADD80)
  {
+    if (len >= 256) return UINT_MAX;
+
    tmp[len++] = 0x80;
  }

  if (hashconfig->opts_type & OPTS_TYPE_ST_ADD01)
  {
+    if (len >= 256) return UINT_MAX;
+
    tmp[len++] = 0x01;
  }