mirror of
https://github.com/trezor/trezor-firmware.git
synced 2024-10-14 03:49:25 +00:00
af98a4071a
We can now selectively runxfail certain tests. This is useful for
accepting PRs into trezor-core:
1. trezor-core is going to get a pytest.ini that sets xfail_strict.
That means that if an `xfail`ed test actually passes, that will
break the test suite. So it will be visible when we implement
a feature for which tests exist.
2. To allow PRs to pass the test suite without touching python-trezor
directly, we add a new pytest.ini option: run_xfail.
This adds a list of markers which will ignore `xfail`.
So:
2.1 First, the python-trezor PR marks the tests with the name
of the feature. This commit already does that: Lisk tests
are marked `@pytest.mark.lisk`, NEMs are `@pytest.mark.nem`,
etc.
The tests will be also marked with `xfail`, because the
feature is not in core yet.
2.2 Then, the trezor-core PR implements the feature, which makes
the `xfail`ed tests pass. That breaks the test suite.
2.3 To fix the test suite, the core PR also adds a `run_xfail`
to `pytest.ini`: `run_xfail = lisk`.
(it can take a list: `run_xfail = lisk nem stellar`)
That will make the test suite behave as if the tests are not
`xfail`ed. If the feature is implemented correctly, the tests
will pass.
2.4 When the PR is accepted to core, the next step should be
a PR to python-trezor that removes the `xfail`s. After that,
we should also remove the `run_xfail` option, just to be tidy.
|
||
|---|---|---|
| .. | ||
| __init__.py | ||
| .gitignore | ||
| common.py | ||
| conftest.py | ||
| test_basic.py | ||
| test_bip32_speed.py | ||
| test_cosi.py | ||
| test_debuglink.py | ||
| test_msg_applysettings.py | ||
| test_msg_changepin.py | ||
| test_msg_cipherkeyvalue.py | ||
| test_msg_clearsession.py | ||
| test_msg_ethereum_getaddress.py | ||
| test_msg_ethereum_signmessage.py | ||
| test_msg_ethereum_signtx.py | ||
| test_msg_ethereum_verifymessage.py | ||
| test_msg_getaddress_segwit_native.py | ||
| test_msg_getaddress_segwit.py | ||
| test_msg_getaddress_show.py | ||
| test_msg_getaddress.py | ||
| test_msg_getecdhsessionkey.py | ||
| test_msg_getentropy.py | ||
| test_msg_getpublickey_curve.py | ||
| test_msg_getpublickey.py | ||
| test_msg_lisk_getaddress.py | ||
| test_msg_lisk_getpublickey.py | ||
| test_msg_lisk_signmessage.py | ||
| test_msg_lisk_signtx.py | ||
| test_msg_lisk_verifymessage.py | ||
| test_msg_loaddevice_xprv.py | ||
| test_msg_loaddevice.py | ||
| test_msg_nem_getaddress.py | ||
| test_msg_nem_signtx_mosaics_t2.py | ||
| test_msg_nem_signtx_mosaics.py | ||
| test_msg_nem_signtx_multisig.py | ||
| test_msg_nem_signtx_others.py | ||
| test_msg_nem_signtx_transfers.py | ||
| test_msg_ping.py | ||
| test_msg_recoverydevice_dryrun.py | ||
| test_msg_recoverydevice_t2.py | ||
| test_msg_recoverydevice.py | ||
| test_msg_resetdevice_skipbackup.py | ||
| test_msg_resetdevice_t2.py | ||
| test_msg_resetdevice.py | ||
| test_msg_signidentity.py | ||
| test_msg_signmessage_segwit_native.py | ||
| test_msg_signmessage_segwit.py | ||
| test_msg_signmessage.py | ||
| test_msg_signtx_bcash.py | ||
| test_msg_signtx_bitcoin_gold.py | ||
| test_msg_signtx_decred.py | ||
| test_msg_signtx_segwit_native.py | ||
| test_msg_signtx_segwit.py | ||
| test_msg_signtx_zcash.py | ||
| test_msg_signtx.py | ||
| test_msg_stellar_get_public_key.py | ||
| test_msg_stellar_sign_message.py | ||
| test_msg_stellar_sign_transaction.py | ||
| test_msg_stellar_verify_message.py | ||
| test_msg_verifymessage_segwit_native.py | ||
| test_msg_verifymessage_segwit.py | ||
| test_msg_verifymessage.py | ||
| test_msg_wipedevice.py | ||
| test_multisig_change.py | ||
| test_multisig.py | ||
| test_op_return.py | ||
| test_protect_call.py | ||
| test_protection_levels.py | ||
| test_zerosig.py | ||