mirror of
https://github.com/trezor/trezor-firmware.git
synced 2024-11-27 18:08:15 +00:00
43677c6afd
The static replacer doesn't understand tuples (it's just a dumb sed, we'd need to teach it the python ast which is a somewhat bigger project that would also make the build slower) so instead we spell out every "utils.INTERNAL_MODEL == xyz" equality check separately. If you don't, you don't get static replacement and you're checking at run-time in every firmware for every device. This pylint will catch the problem. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| pyproject.toml | ||
| README.md | ||
| trezor_pylint_plugin.py | ||
Custom Pylint rule checker
For now, it catches the following problem (async-awaitable-return):
async def show_foo() -> Awaitable[None]:
return show_something("foo")
This is almost certainly a mistake -- the caller would need to say await (await show_foo()) to actually show the foo.
The function should be one of:
async def show_foo() -> None:
return await show_something("foo")
# ... or ...
def show_foo() -> Awaitable[None]:
return show_something("foo")