trezor-firmware

Commit Graph

Author	SHA1	Message	Date
matejcik	43677c6afd	style(core): add check for utils.INTERNAL_MODEL in (tuple) The static replacer doesn't understand tuples (it's just a dumb sed, we'd need to teach it the python ast which is a somewhat bigger project that would also make the build slower) so instead we spell out every "utils.INTERNAL_MODEL == xyz" equality check separately. If you don't, you don't get static replacement and you're checking at run-time in every firmware for every device. This pylint will catch the problem.	3 weeks ago
matejcik	f0d6539d3d	feat: custom Pylint plugin for now, it catches the following incorrect function: async def show_foo() -> Awaitable[None]: return show_something_else("foo") because to correctly show the result, the caller would have to "await (await show_foo())" (this should either be "async def show_foo() -> None", or "def show_foo() -> Awaitable[None]")	10 months ago

Author

SHA1

Message

Date

matejcik

43677c6afd

style(core): add check for utils.INTERNAL_MODEL in (tuple)

The static replacer doesn't understand tuples (it's just a dumb sed,
we'd need to teach it the python ast which is a somewhat bigger project
that would also make the build slower)
so instead we spell out every "utils.INTERNAL_MODEL == xyz" equality
check separately.

If you don't, you don't get static replacement and you're checking at
run-time in every firmware for every device.

This pylint will catch the problem.

matejcik

f0d6539d3d

feat: custom Pylint plugin

for now, it catches the following incorrect function:

async def show_foo() -> Awaitable[None]:
    return show_something_else("foo")

because to correctly show the result, the caller would have to "await (await show_foo())"

(this should either be "async def show_foo() -> None", or "def show_foo() -> Awaitable[None]")

2 Commits (ed1378d638cbcc87b3ab4c9654d5a00c26da86b8)