Ethereum's verify_function takes an actual address as an argument not a
derivation path. So any path validation does not make any sense.
Also, if the verify_recover function raises an exception, it gets
propogated as a DataError (additional fix for #422).
This fixes the problem where the user disconnects a device, connects a
different one, and the library doesn't notice because opening the same
HID path worked fine. (see https://github.com/spesmilo/electrum/issues/4806 )
Previously if an import of a dependent module (usb1, hid) failed, import
of the whole transport module would fail. This was resolved by catching
ImportErrors in the all_transports method.
This had two drawbacks:
- if something other than ImportError happened - e.g., libusb would
raise OSError if it couldn't find libusb.so - all_transports would crash
anyway
- at the same time, if a legitimately needed dependency
(typing_extensions) was missing, this would be masked by the ImportError
handling.
Instead, we unconditionally import the modules, and inside each one,
wrap dependencies in a try-except.
As an added benefit, it is now possible to disable a transport just by
setting SomeTransport.ENABLED = False
move all methods that are still relevant to TrezorClient (originally
BaseClient)
modify ProtocolMixin to be a compatibility shim
modify BaseClient to be a compatibility shim with a proxy to original
actual TrezorClient - this prevents early failures in Electrum for long
enough to show an error message
Only a limited number of messages should be dispatched to handlers
that can be inserted anywhere in the protocol flow. Having a fixed list
of interjecting handlers makes this clearer and prevents hard-to-find
bugs.
Because CTPM dislikes being polled when no touches are seen, keeps
resetting, and maybe freezes once in a while. This is very likely a fix
for #334.
Before, we would simply read the touch registers on every loop. Now we
first check whether the interrupt line is down, which indicates that the
CTPM has data to tell us.
Tracking the `touching` flag is necessary, as sometimes we don't poll
frequently enough to catch the TOUCH_END event before interrupt line
goes up again.
The `last_packet` handling miiight not be necessary - AFAICT, the CTPM
has some sort of buffer and always returns TOUCH_START at first and
TOUCH_END at last. Still, better safe than sorry.
- move bitcoin wallet links from coins_details.override.json to a separate
wallets.json file
- drop NanoWallet links from nem nem_mosaics.json, auto-add them in
coins_details.py instead
- move misc wallet links to misc.json
- clean out override file
- change wallet format in coins_details.json:
- they're now list instead of dict, so that we can specify ordering
- add Trezor Beta wallet link to ETH/ETC and their tokens
- somewhat stricter checking of trezor.io wallet data
Increase version for DGB to 1.6.3 and 2.0.7. Motivation is to make it work seamlessly in current webwallet. Lower versions would need some workarounds.
