trezor-firmware

Commit Graph

Author	SHA1	Message	Date
Alois Klink	5c4703c9bb	fix(core,legacy): Fix domain-only ethTypedData When doing Ethereum signTypedData, and the primaryType="EIP712Domain", we completely ignore the "message" part and only sign the domain. According to the community, this is technically allowed by the spec, and may be used by ETH smart contracts to save on gas. Test case generated by @MetaMask/eth-sig-util's library. See: https://ethereum-magicians.org/t/eip-712-standards-clarification-primarytype-as-domaintype/3286	2 years ago
matejcik	e20879189f	style(core): remove old-style annotations (Set, Tuple, Union)	2 years ago
grdddj	9fc5bb546b	style(core): full pyright-based type-checking Changes many fields to required -- as far as we were able to figure out, signing would fail if these fields aren't provided anyway, so this should not pose a compatibility problem. Co-authored-by: matejcik <ja@matejcik.cz>	2 years ago
grdddj	73238135d6	feat(core/ethereum): EIP-712 Based on original contribution by Max Kupriianov <xlab@hey.com> Implemented EIP-712 typed data signatures in Ethereum app. Add eth_abi into pyproject deps device test for EIP 712 fixed hex decoding for address fixup! fixed hex decoding for address code quality, more pythonic code, removing unused imports running black and isort on changed files trezorctl file input for EIP 712 data signing fixup! code quality, more pythonic code, removing unused imports fixup! fixup! code quality, more pythonic code, removing unused imports necessary changes after rebase to master unit tests for sign_typed_data.py new protobuf messages, working for nonarray types simplified and verified solution for our simple data support for simple arrays, without their confirmation reverting protobuf value messages to bytes, appropriate changes showing arrays in Trezor, code quality improvements data validation on Trezor, minor improvements using custom types for storing type data instead of dicts, addressing feedback from review moving helper functions to its own file, tests for decode_data additional overall tests support for arrays of structs adding support for metamask_v4_compat variable using HashWriter object to collect the final hash continously minor improvements in code quality validate_field_type function streaming values from client without saving them, missing UI prototype of streamed UI using confirm_properties accounting for bytes in data, more data types in integration tests rebase on master, using f-strings minor fixes and improvements from code review StructHasher class for the whole hashing process mypy and style changes asking users whether to show structs and arrays protobuf descriptions to fix make defs_check unifying comments, mypy fix unit tests for StructHasher class UI fixtures, skipping device tests for T1 addressing majority of code review comments about code quality and structure changing file structure - layouts, helpers, sign_typed_data decode_data renaming and docstring, renaming unit test file using tuples instead of lists in elifs layout improvements excluding core/src/apps/common/confirm.py file from the PR True/False returning layout with Show more button code review layout improvements forgotten br_type argument to should_show_more	3 years ago
Martin Milata	3882b89be9	fix(core/ethereum): ask before showing paginated data field	3 years ago
amadejpapez	85ba7c12ba	style(all): use f-strings for formatting [no changelog]	3 years ago
matejcik	e80077e0a4	feat(core/ethereum): enable type-checking for Ethereum app	3 years ago
matejcik	0c2863fc8d	feat(core/ethereum): use TokenInfo object instead of tuples	3 years ago
matejcik	96ed53cc1c	refactor(core,legacy): remove Wanchain special handling now that Wanchain has proper chainID and we don't need to detect it by magic. [no changelog]	3 years ago
Frederik Bolding	38fa9197ca	feat(core,python): support for Ethereum EIP1559 transactions Initial EIP1559 implementation Fix a few small issues Progress on Python lib implementation and firmware Fix RLP length Start fixing tests Fix legacy transactions Simplify API and logic Add EIP1559 tests Fix access list formatting Fix UI visiblity issue Fix commented out code fix: correct linting issues Fix access_list protobuf formatting Remove unneeded code Remove dead code Check tx_type bounds for EIP 2718 Reduce code duplication Prefer eip2718_type over re-using tx_type Add more tests Simplify format_access_list Simplify sign_tx slightly Change Access List format and add logic to encode it Fix a bunch of small PR comments Fix a linting issue Move tests out of class and regenerate Remove copy-pasted comments Add access list to CLI Simplify _parse_access_list_item Fix small mistakes following rebase Fix linting Refactor to use a separate message for EIP 1559 tx Simplify changed legacy code Fix a few small PR comments Fix linting fix(legacy): recognize SignTxEIP1559 on legacy build Fix PR comments	3 years ago
Martin Milata	2a91052b02	refactor(core/ui): move altcoin and webauthn layouts to separate file Also fix types.	3 years ago
matejcik	ad6976e01f	refactor(core): use confirm_blob instead of confirm_hex in apps	3 years ago
Martin Milata	6c926ad82e	refactor(core): convert apps.ethereum to layouts	3 years ago
Jan Pochyla	a8623c4b59	refactor(core): fix imports and use new protobuf API in apps	3 years ago
Martin Milata	b1e38fe382	refactor(core): no implicit spaces in render_text	3 years ago
Martin Milata	f1382bf892	refactor(core): model-dependent UI component directories They now live under trezor.ui.components.tt. Later trezor.ui.components.t1 will be added and application code will be rewritten to not use them directly in order to work on both TT and T1.	3 years ago
matejcik	7abe70e484	feat(core): improve ethereum tokens ui (fixes #800 )	4 years ago
matejcik	4ca8f7b0d6	style(core): use relative imports everywhere except Monero, which has a rather complex structure and I don't want to search&replace mess with it in case some of the things break memory layout	4 years ago
Tomas Susanka	0053511c66	utils: introduce format_plural and move format functions to strings.py	4 years ago
Jan Pochyla	36534325f0	core: revamp the UI subsystem	5 years ago
Konnor Klashinsky	fe65a70dce	Do not display token values in Wei for low-decimal value tokens (#141 ) * Do not display token values in Wei for low-decimal value tokens * update logic * add unit tests	5 years ago
matejcik	e5670856a2	MONOREPO CREATE FROM trezor-core	5 years ago

22 Commits (5c4703c9bbfb962fbbe409c2e40030f30161e4f0)