trezor-firmware

Commit Graph

Author	SHA1	Message	Date
Martin Novak	58276a7443	feat(core/ethereum, legacy/ethereum): add support to Ledger Live legacy derivation path	2 years ago
matejcik	0b9f7db742	fix(core): support structs as array elements (fixes #2167 )	2 years ago
Alois Klink	5c4703c9bb	fix(core,legacy): Fix domain-only ethTypedData When doing Ethereum signTypedData, and the primaryType="EIP712Domain", we completely ignore the "message" part and only sign the domain. According to the community, this is technically allowed by the spec, and may be used by ETH smart contracts to save on gas. Test case generated by @MetaMask/eth-sig-util's library. See: https://ethereum-magicians.org/t/eip-712-standards-clarification-primarytype-as-domaintype/3286	2 years ago
matejcik	d2ac4e7a9c	feat(tests): add tests for blind EIP-712 signing Co-authored-by: Martin Milata <martin@martinmilata.cz> Co-authored-by: grdddj <jiri.musil06@seznam.cz>	3 years ago
grdddj	73238135d6	feat(core/ethereum): EIP-712 Based on original contribution by Max Kupriianov <xlab@hey.com> Implemented EIP-712 typed data signatures in Ethereum app. Add eth_abi into pyproject deps device test for EIP 712 fixed hex decoding for address fixup! fixed hex decoding for address code quality, more pythonic code, removing unused imports running black and isort on changed files trezorctl file input for EIP 712 data signing fixup! code quality, more pythonic code, removing unused imports fixup! fixup! code quality, more pythonic code, removing unused imports necessary changes after rebase to master unit tests for sign_typed_data.py new protobuf messages, working for nonarray types simplified and verified solution for our simple data support for simple arrays, without their confirmation reverting protobuf value messages to bytes, appropriate changes showing arrays in Trezor, code quality improvements data validation on Trezor, minor improvements using custom types for storing type data instead of dicts, addressing feedback from review moving helper functions to its own file, tests for decode_data additional overall tests support for arrays of structs adding support for metamask_v4_compat variable using HashWriter object to collect the final hash continously minor improvements in code quality validate_field_type function streaming values from client without saving them, missing UI prototype of streamed UI using confirm_properties accounting for bytes in data, more data types in integration tests rebase on master, using f-strings minor fixes and improvements from code review StructHasher class for the whole hashing process mypy and style changes asking users whether to show structs and arrays protobuf descriptions to fix make defs_check unifying comments, mypy fix unit tests for StructHasher class UI fixtures, skipping device tests for T1 addressing majority of code review comments about code quality and structure changing file structure - layouts, helpers, sign_typed_data decode_data renaming and docstring, renaming unit test file using tuples instead of lists in elifs layout improvements excluding core/src/apps/common/confirm.py file from the PR True/False returning layout with Show more button code review layout improvements forgotten br_type argument to should_show_more	3 years ago
grdddj	1a291660e5	chore(tests): improving consistency of ethereum fixtures	3 years ago
matejcik	96ed53cc1c	refactor(core,legacy): remove Wanchain special handling now that Wanchain has proper chainID and we don't need to detect it by magic. [no changelog]	3 years ago
arbitrarylink	f051225730	feat(core,legacy): add support for Ethereum 64-bit chain_id * Changes from original PR * Now that we are rejecting chain_ids of 0, we need to have the tests set the chain_ids to at least 1. * Ran 'make gen' and uploaded changed files. * Ran make style_check and fixed reported errors * Added changelog files * Reverted changes concerning chain_id 0 being rejected. * Adds tests for MAX_CHAIN_ID and MAX_CHAIN_ID+1. Also reverts MAX_CHAIN_ID to the previous value. * Added missing whitespace around arithmetic operator. Co-authored-by: Michael Hatton <michaelhatton@Michaels-Mini.fios-router.home>	3 years ago
grdddj	6f1005b155	chore(tests): vectorizing and creating JSON fixtures for ethereum device tests	3 years ago

9 Commits (58276a744383a65d62d1628995d409ebbd6068cf)