trezor-firmware

Commit Graph

Author	SHA1	Message	Date
matejcik	e859c13d70	refactor(core): limit global imports in key places so that by importing `apps.base`, we don't pull in the whole circus	3 years ago
Martin Milata	ac711fb8ee	style(core): use more recent type annotation syntax https://www.python.org/dev/peps/pep-0585/ - Type Hinting Generics In Standard Collections https://www.python.org/dev/peps/pep-0604/ - Allow writing union types as X \| Y	4 years ago
matejcik	5c93ecd53a	core: create top-level storage module This is to avoid including app-specific functionality in storage and avoid circular imports. The following policy is now in effect: modules from `storage` namespace must not import from `apps` namespace. In most files, the change only involves changing import paths. A minor refactor was needed in case of webauthn: basic get/set/delete functionality was left in storage.webauthn, and more advanced logic on top of it was moved to apps.webauthn.resident_credentials. A significant refactor was needed for sd_salt, where application (and UI) logic was tightly coupled with the IO code. This is now separated, and storage.sd_salt deals exclusively with the IO side, while the app/UI logic is implemented on top of it in apps.common.sd_salt and apps.management.sd_protect.	5 years ago

Author

SHA1

Message

Date

matejcik

e859c13d70

refactor(core): limit global imports in key places

so that by importing `apps.base`, we don't pull in the whole circus

Martin Milata

ac711fb8ee

style(core): use more recent type annotation syntax

https://www.python.org/dev/peps/pep-0585/ - Type Hinting Generics In Standard Collections
https://www.python.org/dev/peps/pep-0604/ - Allow writing union types as X | Y

matejcik

5c93ecd53a

core: create top-level storage module

This is to avoid including app-specific functionality in storage and
avoid circular imports. The following policy is now in effect: modules
from `storage` namespace must not import from `apps` namespace.

In most files, the change only involves changing import paths.

A minor refactor was needed in case of webauthn: basic get/set/delete
functionality was left in storage.webauthn, and more advanced logic on
top of it was moved to apps.webauthn.resident_credentials.

A significant refactor was needed for sd_salt, where application (and
UI) logic was tightly coupled with the IO code. This is now separated,
and storage.sd_salt deals exclusively with the IO side, while the app/UI
logic is implemented on top of it in apps.common.sd_salt and
apps.management.sd_protect.

3 Commits (421eec1d3b085ed19878c44409cd7e3132f10c37)