trezor-firmware

Commit Graph

Author	SHA1	Message	Date
matejcik	c414e8abfa	style: update isort and new relative-import sorting rules	6 years ago
Tomas Susanka	1105ba2039	Revert "style" This reverts commit `e52ec86846`.	6 years ago
Tomas Susanka	e52ec86846	style	6 years ago
matejcik	f236eb9cf2	flake8: add typing imports where missing also remove autoflake workarounds from some files, apparently newer autoflake can recognize them properly	6 years ago
matejcik	69ef1f0acd	transport: cleaner Transport list instantiation Previously if an import of a dependent module (usb1, hid) failed, import of the whole transport module would fail. This was resolved by catching ImportErrors in the all_transports method. This had two drawbacks: - if something other than ImportError happened - e.g., libusb would raise OSError if it couldn't find libusb.so - all_transports would crash anyway - at the same time, if a legitimately needed dependency (typing_extensions) was missing, this would be masked by the ImportError handling. Instead, we unconditionally import the modules, and inside each one, wrap dependencies in a try-except. As an added benefit, it is now possible to disable a transport just by setting SomeTransport.ENABLED = False	6 years ago
matejcik	d3534a15c9	transport: fix typing after autoflake treatment autoflake will remove all unused imports when `make style` is invoked, but can't recognize typing names that are only used in comments. this fixes it.	6 years ago
matejcik	bfb56451e8	bridge: support bridge 2.0.25+ which can do read/write separately and supports debuglink	6 years ago
matejcik	daf97afb37	bridge: refactor after merging old changes	6 years ago
matejcik	aac7726824	trezorlib: transport/protocol reshuffle This commit breaks session handling (which matters with Bridge) and regresses Bridge to an older code state. Both of these issues will be rectified in subsequent commits. Explanation of this big API reshuffle follows: * protocols are moved to trezorlib.transport, and to a single common file. * there is a cleaner definition of Transport and Protocol API (see below) * fully valid mypy type hinting * session handle counters and open handle counters mostly went away. Transports and Protocols are meant to be "raw" APIs; TrezorClient will implement context-handler-based sessions, session tracking, etc. I'm calling this a "reshuffle" because it involved very small number of code changes. Most of it is moving things around where they sit better. The API changes are as follows. Transport is now a thing that can: * open and close sessions * read and write protobuf messages * enumerate and find devices Some transports (all except bridge) are technically bytes-based and need a separate protocol implementation (because we have two existing protocols, although only the first one is actually used). Hence a protocol superclass. Protocol is a thing that also can: * open and close sessions * read and write protobuf messages For that, it requires a `handle`. Handle is a physical layer for a protocol. It can: * open and close some sort of device connection (this is distinct from session! Connection is a channel over which you can send data. Session is a logical arrangement on top of that; you can have multiple sessions on a single connection.) * read and write 64-byte chunks of data With that, we introduce ProtocolBasedTransport, which simply delegates the appropriate Transport functionality to respective Protocol methods. hid and webusb transports are ProtocolBasedTransport-s that provide separate device handles. HidHandle and WebUsbHandle existed before, but the distinction of functionality between a Transport and its Handle was unclear. Some methods were moved and now the handles implement the Handle API, while the transports provide the enumeration parts of the Transport API, as well as glue between the respective Protocols and Handles. udp transport is also a ProtocolBasedTransport, but it acts as its own handle. (That might be changed. For now, I went with the pre-existing structure.) In addition, session_begin/end is renamed to begin/end_session to keep consistent verb_noun naming.	6 years ago
matejcik	88988172b9	bridge: perform HTTP request in `read`, not `write` This allows us to return early from a `write`, which we need in cases where we want to perform an operation inbetween `read` and `write` - namely, callback for ButtonRequest should technically be invoked after returning ButtonAck but before waiting for device's response. Of course that doesn't really work. The callback will actually be invoked _before_ ButtonAck, so there's still the condition that it must return immediately or the device gets stuck with a black screen. But doing this allows us to write code as if it worked, which lets the other transports run free and wild, by which I mean, do the Right Thing	6 years ago
Pavol Rusnak	4a0ca873eb	trezorlib+tools: remove usage of binascii	6 years ago
matejcik	3d3e9b67b4	style: apply black/isort	6 years ago
matejcik	29f928e4f2	style: bare excepts, left-over bad imports	6 years ago
matejcik	5259146a0b	style: remove unused imports with autoflake	6 years ago
matejcik	54f1599a5a	regenerate license headers This clarifies the intent: the project is licenced under terms of LGPL version 3 only, but the standard headers cover only "3 or later", so we had to rewrite them. In the same step, we removed author information from individual files in favor of "SatoshiLabs and contributors", and include an AUTHORS file that lists the contributors. Apologies to those whose names are missing; please contact us if you wish to add your info to the AUTHORS file.	6 years ago
matejcik	e779a251fb	transport: better ways to handle errors when enumerating devices	6 years ago
matejcik	97fa4670ac	transport: add message logging to bridge	6 years ago
matejcik	bc8120230a	trezorlib/transport: make changes to support being a separate submodule, move common functions to superclass	7 years ago
matejcik	473ea19570	trezorlib/transport: rename files as separate step (to make diffs nicer)	7 years ago

19 Commits (34052af9db71e5be46f23f812505a6f844e0b88e)