arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-02-17 01:52:02 +00:00
Code Issues Releases Wiki Activity

firmware/storage: cache PIN after set

Browse Source
This commit is contained in:
Pavol Rusnak 2018-12-12 17:37:08 +01:00
parent 0cf5ef837f
commit fa3481e37d
No known key found for this signature in database
GPG Key ID: 91F3B339B9A02A3D
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
firmware/storage.c
View File

@ -246,7 +246,7 @@ void session_clear(bool clear_pin)
sessionPassphraseCached = false; sessionPassphraseCached = false;
memzero(&sessionPassphrase, sizeof(sessionPassphrase)); memzero(&sessionPassphrase, sizeof(sessionPassphrase));
if (clear_pin) { if (clear_pin) {
sessionPinCached = false; session_uncachePin();
} }
} }
@ -290,9 +290,6 @@ static void storage_commit_locked(bool update)
sessionSeedCached = false; sessionSeedCached = false;
sessionPassphraseCached = false; sessionPassphraseCached = false;
} }
if (storageUpdate.has_pin) {
sessionPinCached = false;
}
storageUpdate.version = STORAGE_VERSION; storageUpdate.version = STORAGE_VERSION;
if (!storageUpdate.has_node && !storageUpdate.has_mnemonic) { if (!storageUpdate.has_node && !storageUpdate.has_mnemonic) {
@ -678,7 +675,7 @@ void storage_setPin(const char *pin)
{ {
storageUpdate.has_pin = true; storageUpdate.has_pin = true;
strlcpy(storageUpdate.pin, pin, sizeof(storageUpdate.pin)); strlcpy(storageUpdate.pin, pin, sizeof(storageUpdate.pin));
sessionPinCached = false; session_cachePin();
} }
const char *storage_getPin(void) const char *storage_getPin(void)
@ -729,6 +726,11 @@ void session_cachePin(void)
sessionPinCached = true; sessionPinCached = true;
} }
void session_uncachePin(void)
{
sessionPinCached = false;
}
bool session_isPinCached(void) bool session_isPinCached(void)
{ {
return sessionPinCached; return sessionPinCached;

1
firmware/storage.h
View File

@ -122,6 +122,7 @@ bool storage_hasPin(void);
const char *storage_getPin(void); const char *storage_getPin(void);
void storage_setPin(const char *pin); void storage_setPin(const char *pin);
void session_cachePin(void); void session_cachePin(void);
void session_uncachePin(void);
bool session_isPinCached(void); bool session_isPinCached(void);
void storage_clearPinArea(void); void storage_clearPinArea(void);
void storage_resetPinFails(uint32_t flash_pinfails); void storage_resetPinFails(uint32_t flash_pinfails);