arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-11-26 01:18:28 +00:00
Code Issues Releases Wiki Activity

feat(tests): raise a warning for a translation not found in language

Browse Source 
we need to propagate stacklevel so that the warning is emitted at the
usage line instead of deep in translations.py

i mean
we don't _need_ need to
it's just nicer
This commit is contained in:
matejcik 2024-11-19 11:27:48 +01:00
parent a1033c0e5f
commit f9218ae59e
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tests/translations.py
View File

@ -1,6 +1,7 @@
import json import json
import re import re
import threading import threading
import warnings
import typing as t import typing as t
from hashlib import sha256 from hashlib import sha256
from pathlib import Path from pathlib import Path
@ -93,20 +94,24 @@ class Translation:
def translations(self) -> dict[str, str]: def translations(self) -> dict[str, str]:
return self.lang_json["translations"] return self.lang_json["translations"]
def _translate_raw(self, key: str) -> str: def _translate_raw(self, key: str, _stacklevel: int = 0) -> str:
tr = self.translations.get(key) tr = self.translations.get(key)
if tr is not None: if tr is not None:
return tr return tr
if self.lang != "en": if self.lang != "en":
warnings.warn(
f"Translation key '{key}' not found in '{self.lang}' translation file",
stacklevel=_stacklevel + 2,
)
return TRANSLATIONS["en"]._translate_raw(key) return TRANSLATIONS["en"]._translate_raw(key)
raise KeyError(key) raise KeyError(key)
def translate(self, key: str) -> str: def translate(self, key: str, _stacklevel: int = 0) -> str:
tr = self._translate_raw(key) tr = self._translate_raw(key, _stacklevel=_stacklevel + 1)
return tr.replace("\xa0", " ").strip() return tr.replace("\xa0", " ").strip()
def as_regexp(self, key: str) -> re.Pattern: def as_regexp(self, key: str, _stacklevel: int = 0) -> re.Pattern:
tr = self.translate(key) tr = self.translate(key, _stacklevel=_stacklevel + 1)
re_safe = re.escape(tr) re_safe = re.escape(tr)
return re.compile(self.FORMAT_STR_RE.sub(r".*?", re_safe)) return re.compile(self.FORMAT_STR_RE.sub(r".*?", re_safe))
@ -114,13 +119,13 @@ class Translation:
TRANSLATIONS = {lang: Translation(lang) for lang in LANGUAGES} TRANSLATIONS = {lang: Translation(lang) for lang in LANGUAGES}
def translate(key: str) -> str: def translate(key: str, _stacklevel: int = 0) -> str:
return _CURRENT_TRANSLATION.TR.translate(key) return _CURRENT_TRANSLATION.TR.translate(key, _stacklevel=_stacklevel + 1)
def regexp(key: str) -> re.Pattern: def regexp(key: str) -> re.Pattern:
return _CURRENT_TRANSLATION.TR.as_regexp(key) return _CURRENT_TRANSLATION.TR.as_regexp(key, _stacklevel=1)
def __getattr__(key: str) -> str: def __getattr__(key: str) -> str:
return translate(key) return translate(key, _stacklevel=1)