arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-01-12 00:10:58 +00:00
Code Issues Releases Wiki Activity

client.py - refactor Stellar signing loop to make the message flow clearer

Browse Source
This commit is contained in:
ZuluCrypto 2018-04-20 10:33:56 -06:00
parent 94f3f43746
commit ea6ced4dae
No known key found for this signature in database
GPG Key ID: 0D1266F87C28A2E1
1 changed files with 21 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
trezorlib/client.py
View File

@ -1110,25 +1110,33 @@ class ProtocolMixin(object):
if network_passphrase is None: if network_passphrase is None:
network_passphrase = "Public Global Stellar Network ; September 2015" network_passphrase = "Public Global Stellar Network ; September 2015"
parsed = stellar.parse_transaction_bytes(tx_envelope) tx, operations = stellar.parse_transaction_bytes(tx_envelope)
tx = parsed["tx"]
tx.network_passphrase = network_passphrase tx.network_passphrase = network_passphrase
tx.address_n = address_n tx.address_n = address_n
# Will return a StellarTxOpRequest # Signing loop works as follows:
resp = self.call(parsed["tx"]) #
if not isinstance(resp, proto.StellarTxOpRequest): # 1. Start with tx (header information for the transaction) and operations (an array of operation protobuf messagess)
raise CallException("Unexpected response to transaction") # 2. Send the tx header to the device
# 3. Receive a StellarTxOpRequest message
# 4. Send operations one by one until all operations have been sent. If there are more operations to sign, the device will send a StellarTxOpRequest message
# 5. The final message received will be StellarSignedTx which is returned from this method
resp = self.call(tx)
try:
while isinstance(resp, proto.StellarTxOpRequest):
resp = self.call(operations.pop(0))
except IndexError:
# pop from empty list
raise CallException("Stellar.UnexpectedEndOfOperations",
"Reached end of operations without a signature.") from None
# Send each operation to the device.
# The response to the last message should be a StellarSignedTx
for op in parsed["operations"]:
resp = self.call(op)
# Verify expected response message StellarSignedTx and return it
if not isinstance(resp, proto.StellarSignedTx): if not isinstance(resp, proto.StellarSignedTx):
raise CallException("Stellar.UnexpectedEndOfOperations", "Reached end of operations without a signature") raise CallException(proto.FailureType.UnexpectedMessage, resp)
if operations:
raise CallException("Stellar.UnprocessedOperations",
"Received a signature before processing all operations.")
return resp return resp