mirror of
https://github.com/trezor/trezor-firmware.git
synced 2024-11-21 23:18:13 +00:00
tests/upgrade_tests: extract and simplify for_all decorator
This commit is contained in:
matejcik
parent
cdb7a7eb68
commit
e9003d0742
@ -1,8 +1,24 @@
|
||||
# This file is part of the Trezor project.
|
||||
#
|
||||
# Copyright (C) 2012-2019 SatoshiLabs and contributors
|
||||
#
|
||||
# This library is free software: you can redistribute it and/or modify
|
||||
# it under the terms of the GNU Lesser General Public License version 3
|
||||
# as published by the Free Software Foundation.
|
||||
#
|
||||
# This library is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU Lesser General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the License along with this library.
|
||||
# If not, see <https://www.gnu.org/licenses/lgpl-3.0.html>.
|
||||
|
||||
import os
|
||||
|
||||
import pytest
|
||||
|
||||
from ..emulators import LOCAL_BUILD_PATHS
|
||||
from ..emulators import ALL_TAGS, LOCAL_BUILD_PATHS
|
||||
|
||||
SELECTED_GENS = [
|
||||
gen.strip() for gen in os.environ.get("TREZOR_UPGRADE_TEST", "").split(",") if gen
|
||||
@ -26,3 +42,54 @@ legacy_only = pytest.mark.skipif(
|
||||
core_only = pytest.mark.skipif(
|
||||
not CORE_ENABLED, reason="This test requires core emulator"
|
||||
)
|
||||
|
||||
|
||||
def for_all(*args, legacy_minimum_version=(1, 0, 0), core_minimum_version=(2, 0, 0)):
|
||||
"""Parametrizing decorator for test cases.
|
||||
|
||||
Usage example:
|
||||
|
||||
>>> @for_all()
|
||||
>>> def test_runs_for_all_old_versions(gen, tag):
|
||||
>>> assert True
|
||||
|
||||
Arguments can be "core" and "legacy", and you can specify core_minimum_version and
|
||||
legacy_minimum_version as triplets.
|
||||
|
||||
The test function should have arguments `gen` ("core" or "legacy") and `tag`
|
||||
(version tag usable in EmulatorWrapper call)
|
||||
"""
|
||||
if not args:
|
||||
args = ("core", "legacy")
|
||||
|
||||
# If any gens were selected, use them. If none, select all.
|
||||
enabled_gens = SELECTED_GENS or args
|
||||
|
||||
all_params = []
|
||||
for gen in args:
|
||||
if gen == "legacy":
|
||||
minimum_version = legacy_minimum_version
|
||||
elif gen == "core":
|
||||
minimum_version = core_minimum_version
|
||||
else:
|
||||
raise ValueError
|
||||
|
||||
if gen not in enabled_gens:
|
||||
continue
|
||||
try:
|
||||
for tag in ALL_TAGS[gen]:
|
||||
if tag.startswith("v"):
|
||||
tag_version = tuple(int(n) for n in tag[1:].split("."))
|
||||
if tag_version < minimum_version:
|
||||
continue
|
||||
all_params.append((gen, tag))
|
||||
|
||||
# at end, add None tag, which is the current master
|
||||
all_params.append((gen, None))
|
||||
except KeyError:
|
||||
pass
|
||||
|
||||
if not all_params:
|
||||
return pytest.mark.skip("no versions are applicable")
|
||||
|
||||
return pytest.mark.parametrize("gen, tag", all_params)
|
||||
|
||||
@ -14,8 +14,6 @@
|
||||
# You should have received a copy of the License along with this library.
|
||||
# If not, see <https://www.gnu.org/licenses/lgpl-3.0.html>.
|
||||
|
||||
import pytest
|
||||
|
||||
from trezorlib import MINIMUM_FIRMWARE_VERSION, btc, debuglink, device, fido
|
||||
from trezorlib.messages import BackupType
|
||||
from trezorlib.tools import H_
|
||||
@ -24,7 +22,7 @@ from ..click_tests import recovery
|
||||
from ..common import MNEMONIC_SLIP39_BASIC_20_3of6, MNEMONIC_SLIP39_BASIC_20_3of6_SECRET
|
||||
from ..device_handler import BackgroundDeviceHandler
|
||||
from ..emulators import ALL_TAGS, EmulatorWrapper
|
||||
from . import SELECTED_GENS
|
||||
from . import for_all
|
||||
|
||||
MINIMUM_FIRMWARE_VERSION["1"] = (1, 0, 0)
|
||||
MINIMUM_FIRMWARE_VERSION["T"] = (2, 0, 0)
|
||||
@ -40,52 +38,16 @@ LANGUAGE = "en-US"
|
||||
STRENGTH = 128
|
||||
|
||||
|
||||
def for_all(*args, legacy_minimum_version=(1, 0, 0), core_minimum_version=(2, 0, 0)):
|
||||
if not args:
|
||||
args = ("core", "legacy")
|
||||
|
||||
# If any gens were selected, use them. If none, select all.
|
||||
enabled_gens = SELECTED_GENS or args
|
||||
|
||||
all_params = []
|
||||
for gen in args:
|
||||
if gen == "legacy":
|
||||
minimum_version = legacy_minimum_version
|
||||
elif gen == "core":
|
||||
minimum_version = core_minimum_version
|
||||
else:
|
||||
raise ValueError
|
||||
|
||||
if gen not in enabled_gens:
|
||||
continue
|
||||
try:
|
||||
to_tag = None
|
||||
from_tags = ALL_TAGS[gen] + [to_tag]
|
||||
for from_tag in from_tags:
|
||||
if from_tag is not None and from_tag.startswith("v"):
|
||||
tag_version = tuple(int(n) for n in from_tag[1:].split("."))
|
||||
if tag_version < minimum_version:
|
||||
continue
|
||||
all_params.append((gen, from_tag, to_tag))
|
||||
except KeyError:
|
||||
pass
|
||||
|
||||
if not all_params:
|
||||
return pytest.mark.skip("no versions are applicable")
|
||||
|
||||
return pytest.mark.parametrize("gen, from_tag, to_tag", all_params)
|
||||
|
||||
|
||||
@for_all()
|
||||
def test_upgrade_load(gen, from_tag, to_tag):
|
||||
def asserts(tag, client):
|
||||
def test_upgrade_load(gen, tag):
|
||||
def asserts(client):
|
||||
assert not client.features.pin_protection
|
||||
assert not client.features.passphrase_protection
|
||||
assert client.features.initialized
|
||||
assert client.features.label == LABEL
|
||||
assert btc.get_address(client, "Bitcoin", PATH) == ADDRESS
|
||||
|
||||
with EmulatorWrapper(gen, from_tag) as emu:
|
||||
with EmulatorWrapper(gen, tag) as emu:
|
||||
debuglink.load_device_by_mnemonic(
|
||||
emu.client,
|
||||
mnemonic=MNEMONIC,
|
||||
@ -95,18 +57,18 @@ def test_upgrade_load(gen, from_tag, to_tag):
|
||||
language=LANGUAGE,
|
||||
)
|
||||
device_id = emu.client.features.device_id
|
||||
asserts(from_tag, emu.client)
|
||||
asserts(emu.client)
|
||||
storage = emu.get_storage()
|
||||
|
||||
with EmulatorWrapper(gen, to_tag, storage=storage) as emu:
|
||||
with EmulatorWrapper(gen, storage=storage) as emu:
|
||||
assert device_id == emu.client.features.device_id
|
||||
asserts(to_tag, emu.client)
|
||||
asserts(emu.client)
|
||||
assert emu.client.features.language == LANGUAGE
|
||||
|
||||
|
||||
@for_all("legacy")
|
||||
def test_upgrade_reset(gen, from_tag, to_tag):
|
||||
def asserts(tag, client):
|
||||
def test_upgrade_reset(gen, tag):
|
||||
def asserts(client):
|
||||
assert not client.features.pin_protection
|
||||
assert not client.features.passphrase_protection
|
||||
assert client.features.initialized
|
||||
@ -115,7 +77,7 @@ def test_upgrade_reset(gen, from_tag, to_tag):
|
||||
assert not client.features.unfinished_backup
|
||||
assert not client.features.no_backup
|
||||
|
||||
with EmulatorWrapper(gen, from_tag) as emu:
|
||||
with EmulatorWrapper(gen, tag) as emu:
|
||||
device.reset(
|
||||
emu.client,
|
||||
display_random=False,
|
||||
@ -126,20 +88,20 @@ def test_upgrade_reset(gen, from_tag, to_tag):
|
||||
language=LANGUAGE,
|
||||
)
|
||||
device_id = emu.client.features.device_id
|
||||
asserts(from_tag, emu.client)
|
||||
asserts(emu.client)
|
||||
address = btc.get_address(emu.client, "Bitcoin", PATH)
|
||||
storage = emu.get_storage()
|
||||
|
||||
with EmulatorWrapper(gen, to_tag, storage=storage) as emu:
|
||||
with EmulatorWrapper(gen, storage=storage) as emu:
|
||||
assert device_id == emu.client.features.device_id
|
||||
asserts(to_tag, emu.client)
|
||||
asserts(emu.client)
|
||||
assert emu.client.features.language == LANGUAGE
|
||||
assert btc.get_address(emu.client, "Bitcoin", PATH) == address
|
||||
|
||||
|
||||
@for_all()
|
||||
def test_upgrade_reset_skip_backup(gen, from_tag, to_tag):
|
||||
def asserts(tag, client):
|
||||
def test_upgrade_reset_skip_backup(gen, tag):
|
||||
def asserts(client):
|
||||
assert not client.features.pin_protection
|
||||
assert not client.features.passphrase_protection
|
||||
assert client.features.initialized
|
||||
@ -148,7 +110,7 @@ def test_upgrade_reset_skip_backup(gen, from_tag, to_tag):
|
||||
assert not client.features.unfinished_backup
|
||||
assert not client.features.no_backup
|
||||
|
||||
with EmulatorWrapper(gen, from_tag) as emu:
|
||||
with EmulatorWrapper(gen, tag) as emu:
|
||||
device.reset(
|
||||
emu.client,
|
||||
display_random=False,
|
||||
@ -160,20 +122,20 @@ def test_upgrade_reset_skip_backup(gen, from_tag, to_tag):
|
||||
skip_backup=True,
|
||||
)
|
||||
device_id = emu.client.features.device_id
|
||||
asserts(from_tag, emu.client)
|
||||
asserts(emu.client)
|
||||
address = btc.get_address(emu.client, "Bitcoin", PATH)
|
||||
storage = emu.get_storage()
|
||||
|
||||
with EmulatorWrapper(gen, to_tag, storage=storage) as emu:
|
||||
with EmulatorWrapper(gen, storage=storage) as emu:
|
||||
assert device_id == emu.client.features.device_id
|
||||
asserts(to_tag, emu.client)
|
||||
asserts(emu.client)
|
||||
assert emu.client.features.language == LANGUAGE
|
||||
assert btc.get_address(emu.client, "Bitcoin", PATH) == address
|
||||
|
||||
|
||||
@for_all(legacy_minimum_version=(1, 7, 2))
|
||||
def test_upgrade_reset_no_backup(gen, from_tag, to_tag):
|
||||
def asserts(tag, client):
|
||||
def test_upgrade_reset_no_backup(gen, tag):
|
||||
def asserts(client):
|
||||
assert not client.features.pin_protection
|
||||
assert not client.features.passphrase_protection
|
||||
assert client.features.initialized
|
||||
@ -182,7 +144,7 @@ def test_upgrade_reset_no_backup(gen, from_tag, to_tag):
|
||||
assert not client.features.unfinished_backup
|
||||
assert client.features.no_backup
|
||||
|
||||
with EmulatorWrapper(gen, from_tag) as emu:
|
||||
with EmulatorWrapper(gen, tag) as emu:
|
||||
device.reset(
|
||||
emu.client,
|
||||
display_random=False,
|
||||
@ -194,21 +156,21 @@ def test_upgrade_reset_no_backup(gen, from_tag, to_tag):
|
||||
no_backup=True,
|
||||
)
|
||||
device_id = emu.client.features.device_id
|
||||
asserts(from_tag, emu.client)
|
||||
asserts(emu.client)
|
||||
address = btc.get_address(emu.client, "Bitcoin", PATH)
|
||||
storage = emu.get_storage()
|
||||
|
||||
with EmulatorWrapper(gen, to_tag, storage=storage) as emu:
|
||||
with EmulatorWrapper(gen, storage=storage) as emu:
|
||||
assert device_id == emu.client.features.device_id
|
||||
asserts(to_tag, emu.client)
|
||||
asserts(emu.client)
|
||||
assert emu.client.features.language == LANGUAGE
|
||||
assert btc.get_address(emu.client, "Bitcoin", PATH) == address
|
||||
|
||||
|
||||
# Although Shamir was introduced in 2.1.2 already, the debug instrumentation was not present until 2.1.9.
|
||||
@for_all("core", core_minimum_version=(2, 1, 9))
|
||||
def test_upgrade_shamir_recovery(gen, from_tag, to_tag):
|
||||
with EmulatorWrapper(gen, from_tag) as emu, BackgroundDeviceHandler(
|
||||
def test_upgrade_shamir_recovery(gen, tag):
|
||||
with EmulatorWrapper(gen, tag) as emu, BackgroundDeviceHandler(
|
||||
emu.client
|
||||
) as device_handler:
|
||||
assert emu.client.features.recovery_mode is False
|
||||
@ -225,12 +187,10 @@ def test_upgrade_shamir_recovery(gen, from_tag, to_tag):
|
||||
storage = emu.get_storage()
|
||||
device_handler.check_finalize()
|
||||
|
||||
with EmulatorWrapper(gen, to_tag, storage=storage) as emu, BackgroundDeviceHandler(
|
||||
emu.client
|
||||
) as device_handler:
|
||||
with EmulatorWrapper(gen, storage=storage) as emu:
|
||||
assert device_id == emu.client.features.device_id
|
||||
assert emu.client.features.recovery_mode
|
||||
debug = device_handler.debuglink()
|
||||
debug = emu.client.debug
|
||||
|
||||
# second share
|
||||
layout = recovery.enter_share(debug, MNEMONIC_SLIP39_BASIC_20_3of6[2])
|
||||
@ -244,15 +204,12 @@ def test_upgrade_shamir_recovery(gen, from_tag, to_tag):
|
||||
state = debug.state()
|
||||
assert state.mnemonic_secret.hex() == MNEMONIC_SLIP39_BASIC_20_3of6_SECRET
|
||||
assert state.mnemonic_type == BackupType.Slip39_Basic
|
||||
device_handler.check_finalize()
|
||||
|
||||
|
||||
@for_all(legacy_minimum_version=(1, 8, 4), core_minimum_version=(2, 1, 9))
|
||||
def test_upgrade_u2f(gen, from_tag, to_tag):
|
||||
"""
|
||||
Check U2F counter stayed the same after an upgrade.
|
||||
"""
|
||||
with EmulatorWrapper(gen, from_tag) as emu:
|
||||
def test_upgrade_u2f(gen, tag):
|
||||
"""Check U2F counter stayed the same after an upgrade."""
|
||||
with EmulatorWrapper(gen, tag) as emu:
|
||||
success = fido.set_counter(emu.client, 10)
|
||||
assert "U2F counter set" in success
|
||||
|
||||
@ -260,7 +217,7 @@ def test_upgrade_u2f(gen, from_tag, to_tag):
|
||||
assert counter == 11
|
||||
storage = emu.get_storage()
|
||||
|
||||
with EmulatorWrapper(gen, to_tag, storage=storage) as emu:
|
||||
with EmulatorWrapper(gen, storage=storage) as emu:
|
||||
counter = fido.get_next_counter(emu.client)
|
||||
assert counter == 12
|
||||
|
||||
|
||||
Loading…
Reference in New Issue
Block a user