arno
/
trezor-firmware
mirror of https://github.com/trezor/trezor-firmware.git
1
0
Fork 0
Code Issues Releases Wiki Activity

feat(core): Show "signature is valid" dialog when VerifyMessage succeeds.

Browse Source
pull/2126/head
Andrew Kozlik 2 years ago committed by Andrew Kozlik
parent 4d40d6dbfc
commit d52a59e37b
5 changed files with 30 additions and 26 deletions
Show Stats Download Patch File Download Diff File

1
core/.changelog.d/1880.added
Unescape View File

@ -0,0 +1 @@
Show "signature is valid" dialog when VerifyMessage succeeds.

1
core/src/apps/bitcoin/verify_message.py
Unescape View File

@ -108,4 +108,5 @@ async def verify_message(ctx: wire.Context, msg: VerifyMessage) -> Success:
verify=True,
)
await show_success(ctx, "verify_message", "The signature is valid.")
return Success(message="Message verified")

3
core/src/apps/ethereum/verify_message.py
Unescape View File

@ -4,7 +4,7 @@ from trezor import wire
from trezor.crypto.curve import secp256k1
from trezor.crypto.hashlib import sha3_256
from trezor.messages import Success
from trezor.ui.layouts import confirm_signverify
from trezor.ui.layouts import confirm_signverify, show_success
from apps.common.signverify import decode_message
@ -39,4 +39,5 @@ async def verify_message(ctx: Context, msg: EthereumVerifyMessage) -> Success:
ctx, "ETH", decode_message(msg.message), address=address, verify=True
)
await show_success(ctx, "verify_message", "The signature is valid.")
return Success(message="Message verified")

1
tests/device_tests/test_protection_levels.py
Unescape View File

@ -326,6 +326,7 @@ def test_verify_message_t2(client: Client):
_pin_request(client),
messages.ButtonRequest,
messages.ButtonRequest,
messages.ButtonRequest,
messages.Success,
]
)

50
tests/ui_tests/fixtures.json
Unescape View File

@ -375,21 +375,21 @@
"bitcoin-test_signtx_taproot.py::test_send_mixed": "750648ddd29e1eee28bf2d4f292a131821cdf6413ccafbfed88ee5c8f70841b4",
"bitcoin-test_signtx_taproot.py::test_send_p2tr": "3ea24494ae8e004645d31afcd798066a784c44acb613588c407c4717ad9a56d6",
"bitcoin-test_signtx_taproot.py::test_send_two_with_change": "b394ee2dcdc7d8b5906b9b4d7f52ac69af7e9e5f93229980f6450a1d4e83bd9b",
"bitcoin-test_verifymessage.py::test_message_grs": "a927ec214a2ac0a8e0d6d13bde6f20d9cf3847367bf48795dfe43d8b2402d40f",
"bitcoin-test_verifymessage.py::test_message_long": "8dc8c73c4c91bdd98709585ed6df8ffc321845eb29a2e72b7bc6c13d90a42123",
"bitcoin-test_verifymessage.py::test_message_testnet": "fc8de2115ecb5da834a4b8cf9444a98fc4af095e1f0d2c28e9904761ff25924c",
"bitcoin-test_verifymessage.py::test_message_verify": "adc89f7a24565c2fb0cd00ba9b3fdf923268d70f2413df9afaf757a6d2da75c7",
"bitcoin-test_verifymessage.py::test_message_verify_bcash": "a4b2355a8b7649515c67aee5a6a1438ecc94f4c772dc001e624a80f80f719cb7",
"bitcoin-test_verifymessage.py::test_verify_bitcoind": "aa53ce95442a3c78e6a3f559237e1fce2e1c4eba124e32a374a8017ee7a35ab5",
"bitcoin-test_verifymessage.py::test_verify_utf": "5a21d0ce4f5622001a6d54280c10424045a5b4a295dc943b7aa5509e15e3c1cb",
"bitcoin-test_verifymessage_segwit.py::test_message_long": "5a6dbb32d55989eae02b6e6b69b1980172b17c100c3f61175ebd08d3425d8c8f",
"bitcoin-test_verifymessage_segwit.py::test_message_testnet": "9b3605d74cf4787c3d22aa847e2a9009a6a49cd18fd704801b6592972fad09c9",
"bitcoin-test_verifymessage_segwit.py::test_message_verify": "26b96652d888fb9ea63f1f6cdd8e55b81fdb22240952837364df1d56c403d24e",
"bitcoin-test_verifymessage_segwit.py::test_verify_utf": "65509f8958bd561e7a35b33e82ebb74bceca54f4108c2ee10f04f4e491248204",
"bitcoin-test_verifymessage_segwit_native.py::test_message_long": "3939f3b0c021f7116d5c9e34c0f7de7f8358a52af7a24fef27469ee0a62326d6",
"bitcoin-test_verifymessage_segwit_native.py::test_message_testnet": "fafb5d434ce0c8df8b2913253cfc9a6458c83edcf103bfa44168d7911a16e83d",
"bitcoin-test_verifymessage_segwit_native.py::test_message_verify": "b05637d691ee73f2178a85575335559512b038fa779c3476eebeec1f8ef4e63a",
"bitcoin-test_verifymessage_segwit_native.py::test_verify_utf": "eb411fa9e3adfa39c7e801b1917babb7ff1f0a939172b907b686f4b3e5e44d04",
"bitcoin-test_verifymessage.py::test_message_grs": "efba87e334f62f3ee18ce6ac2f6e8ba3738fc53434ad8d4027643d2047945620",
"bitcoin-test_verifymessage.py::test_message_long": "ddd376c7ce7731d990f231a81532dfa13d6a03bc88e5a77278d6eef514b496a2",
"bitcoin-test_verifymessage.py::test_message_testnet": "af4598881e7afbfb81313622d7186cd90e8bdcfdada4a0c0f31ca5f0af5f8d5d",
"bitcoin-test_verifymessage.py::test_message_verify": "74917807cbdc8edc9e2c3e33bc5d8e1e8a712f35898b4a33fe110c73af9ddd92",
"bitcoin-test_verifymessage.py::test_message_verify_bcash": "cf7ffea3154e28c3bd9456c569e70eab9f328c20ff14dfc23e779ac632604651",
"bitcoin-test_verifymessage.py::test_verify_bitcoind": "dc368994deed16caf972c53ef79ede3193d9159397908bcfedc4703bee090e22",
"bitcoin-test_verifymessage.py::test_verify_utf": "452a27dc0cbfd703e9bf980f64aaf1a4d7b2e8bac51a797571a8ba70fc3698d2",
"bitcoin-test_verifymessage_segwit.py::test_message_long": "4fc23422dac54f4793c4da74e519a5509459ba7f45d5cb1e3c09be478f24d60f",
"bitcoin-test_verifymessage_segwit.py::test_message_testnet": "530fdcd115fe58b19f8b8af1f0af403c327c0f76b921e2a54d811f4a66b64d75",
"bitcoin-test_verifymessage_segwit.py::test_message_verify": "43583ce3fcf46783907e34ac24faee1335ef2a8522053752c62f38cf38ca7a32",
"bitcoin-test_verifymessage_segwit.py::test_verify_utf": "6f07f017ab3947b04ce3556f6f38ee5e9841cd73a04edc9c25f74084ef189706",
"bitcoin-test_verifymessage_segwit_native.py::test_message_long": "0f2a09bf56c97dae28ad4457cb63a7e7cebced6fa3fb614c409fbacc818d89cd",
"bitcoin-test_verifymessage_segwit_native.py::test_message_testnet": "f36a0eaed6ff6d64c37fc147a05ec24637aea9a81360d5ba14d6c87db35a6e3a",
"bitcoin-test_verifymessage_segwit_native.py::test_message_verify": "912a94f466108c9d6b67a1cc9aa8b6a2a7d29ab9003c39e9f70aa10b0ff7b5e8",
"bitcoin-test_verifymessage_segwit_native.py::test_verify_utf": "faf3fddc43290a424243562f3ed7598d5127b71b1680aee40e56f0b01d22664a",
"bitcoin-test_zcash.py::test_external_presigned": "08a22a49793201f8387a085a554f006387d1df1b37ed8a34bef7aa79b363b44b",
"bitcoin-test_zcash.py::test_one_one_fee_sapling": "b8aff4ae3c9b417acadf1ede52d7d45870dd4ef1f9251bf8e8f2ebf5280b9f3b",
"bitcoin-test_zcash.py::test_spend_old_versions": "c3f75b5c8ceb63ad2102d270689f55fbf3b204581bec7dcee930f875416e1a07",
@ -633,15 +633,15 @@
"ethereum-test_sign_verify_message.py::test_signmessage[parameters5-result5]": "f37e3cbb718493c0abe9ec76c297594e1ac87253b46273cca74fa498ca7f2703",
"ethereum-test_sign_verify_message.py::test_signmessage[parameters6-result6]": "f6a32113e2edbd33648a8fda20e2cf8c7cfff53d3cf765ff2b945990733a696e",
"ethereum-test_sign_verify_message.py::test_signmessage[parameters7-result7]": "5127f94dd3eec514faec78eedfb22151eef1fd787ea26b4da718a85adb4f8523",
"ethereum-test_sign_verify_message.py::test_verify[parameters0-result0]": "10ec761b50bf9557aac79d885b4dbc64f57b8367e66838f169c86fcbeaba9b50",
"ethereum-test_sign_verify_message.py::test_verify[parameters1-result1]": "1dfc74e93def641c35c7670ffdefc23f9fb0ab6c10e1c208e1c00817f071028c",
"ethereum-test_sign_verify_message.py::test_verify[parameters2-result2]": "2fd7c36a17e41a9a55e92431e3040f569534153d8c2f51e77fc212da283fa0c3",
"ethereum-test_sign_verify_message.py::test_verify[parameters3-result3]": "748d7b99b54d47128ec15291caa7369d0044e629ca294e4560c3a9a092188ca0",
"ethereum-test_sign_verify_message.py::test_verify[parameters4-result4]": "771052d14c6f55be5e054c365b41f83d86e7e8cd02331258c0dba4288253818a",
"ethereum-test_sign_verify_message.py::test_verify[parameters5-result5]": "8cf46785319de4cb4e8112878db17e483e05814479637138dc2b005c8c873fa4",
"ethereum-test_sign_verify_message.py::test_verify[parameters6-result6]": "53034f00e1cbe4bdd3a1ec7bb190ff19c3f913e39cdbb26a2ea1bf7c4d89e09c",
"ethereum-test_sign_verify_message.py::test_verify[parameters7-result7]": "328fd3be37dc09ec3716557d4b70eda5a7cf3f7852e52c5a07950aec9cae80a4",
"ethereum-test_sign_verify_message.py::test_verify_invalid": "10ec761b50bf9557aac79d885b4dbc64f57b8367e66838f169c86fcbeaba9b50",
"ethereum-test_sign_verify_message.py::test_verify[parameters0-result0]": "f56f261951ed30706d692510ea3a8860397bda9abe199f15eaa536d06e8977b1",
"ethereum-test_sign_verify_message.py::test_verify[parameters1-result1]": "1686bb7cd461671063e19d27b48874d186aa687703600a3b19841843c64ac20b",
"ethereum-test_sign_verify_message.py::test_verify[parameters2-result2]": "6cb31eafe466b821cb8b825f00968bf50c322494940aecb94036df9bfcf897ea",
"ethereum-test_sign_verify_message.py::test_verify[parameters3-result3]": "da02cbffb0124e4eaf2dd20d44a6766b25479f49339c7cac55ffa430bd2be8e5",
"ethereum-test_sign_verify_message.py::test_verify[parameters4-result4]": "be1dd2a0901ff4ac6a1578d5609b77a559a0bd95ec5494f27db0571e58e47970",
"ethereum-test_sign_verify_message.py::test_verify[parameters5-result5]": "4991ac69edf49f029750c807b60597f01d9d106d2496f9d2c215f5d300d3e292",
"ethereum-test_sign_verify_message.py::test_verify[parameters6-result6]": "8a04d5a6b192e5fa20b76574457b6dd8f6a7796949bad7c1df9231eafd0c8dc7",
"ethereum-test_sign_verify_message.py::test_verify[parameters7-result7]": "03c6cc044648959592b297eda1239da7d379385b6483c61abdb6d3db1ecd40f9",
"ethereum-test_sign_verify_message.py::test_verify_invalid": "f56f261951ed30706d692510ea3a8860397bda9abe199f15eaa536d06e8977b1",
"ethereum-test_signtx.py::test_data_streaming": "e0e6179a08c7a96958814d95ddfe09996a96aefeec3f538acfa58844c664d90f",
"ethereum-test_signtx.py::test_sanity_checks": "c09de07fbbf1e047442180e2facb5482d06a1a428891b875b7dd93c9e4704ae1",
"ethereum-test_signtx.py::test_sanity_checks_eip1559": "c09de07fbbf1e047442180e2facb5482d06a1a428891b875b7dd93c9e4704ae1",
@ -903,7 +903,7 @@
"test_protection_levels.py::test_sign_message": "045d2faee841a79441683a6fdc912c3c69ecc0289b6c9801580942d47af7f0de",
"test_protection_levels.py::test_signtx": "f13f1687e062bd407dc781ae93ebb6619eee5ea3d37ee031ffdc98d5bd7aea33",
"test_protection_levels.py::test_unlocked": "f2be4c8c13c6a201770966438ffa9bcfe0eb031683920f93a55fa92921a28b51",
"test_protection_levels.py::test_verify_message_t2": "794f6cad5b4903944061e49e6d0fb74a35786b29b399384736c19ee5ebacd85f",
"test_protection_levels.py::test_verify_message_t2": "0cf43552a15684fbf506cd56871ca07795f62ec5f57176705aa968c9f97ef3d8",
"test_protection_levels.py::test_wipe_device": "a30d958dda50b06e8bfc1c861c0ff2c0eb4acd0656bdf1dcd6474660882e3cd5",
"test_sdcard.py::test_sd_format": "b6da09fabbf0f9f05e2b575650789b2ecae25bdcc0304e14c1e59fa1b4b24d05",
"test_sdcard.py::test_sd_no_format": "28237b70aadc1ce6f3ddfd3c0f9b6b256898cad068b0de333b404989aa0dcc62",

Write Preview
Loading…
Cancel
Save