arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-18 04:18:10 +00:00
Code Issues Releases Wiki Activity

fix(legacy): Fix transaction weight calculation.

Browse Source 
Fix size of multisig script length encoding in segwit (varint vs. OP_PUSH).
This commit is contained in:
Andrew Kozlik 2021-11-13 20:55:17 +01:00 committed by Andrew Kozlik
parent 567cbd0250
commit cafc49fabd
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
legacy/firmware/transaction.c
View File

@ -923,9 +923,14 @@ static uint32_t tx_input_script_size(const TxInputType *txinput) {
uint32_t multisig_script_size = uint32_t multisig_script_size =
TXSIZE_MULTISIGSCRIPT + TXSIZE_MULTISIGSCRIPT +
cryptoMultisigPubkeyCount(&(txinput->multisig)) * (1 + TXSIZE_PUBKEY); cryptoMultisigPubkeyCount(&(txinput->multisig)) * (1 + TXSIZE_PUBKEY);
if (txinput->script_type == InputScriptType_SPENDWITNESS ||
txinput->script_type == InputScriptType_SPENDP2SHWITNESS) {
multisig_script_size += ser_length_size(multisig_script_size);
} else {
multisig_script_size += op_push_size(multisig_script_size);
}
input_script_size = 1 // the OP_FALSE bug in multisig input_script_size = 1 // the OP_FALSE bug in multisig
+ txinput->multisig.m * (1 + TXSIZE_DER_SIGNATURE) + + txinput->multisig.m * (1 + TXSIZE_DER_SIGNATURE) +
op_push_size(multisig_script_size) +
multisig_script_size; multisig_script_size;
} else if (txinput->script_type == InputScriptType_SPENDTAPROOT) { } else if (txinput->script_type == InputScriptType_SPENDTAPROOT) {
input_script_size = 1 + TXSIZE_SCHNORR_SIGNATURE; input_script_size = 1 + TXSIZE_SCHNORR_SIGNATURE;