fix(common): Fix incorrect SLIP-44 coin type for Bgold and SmartCash Testnets.

3 years ago · c067618828
parent 28421594c9
commit c067618828
5 changed files with 6 additions and 4 deletions
--- a/common/defs/bitcoin/bgold_testnet.json
+++ b/common/defs/bitcoin/bgold_testnet.json
@ -21,7 +21,7 @@
  "xpub_magic_multisig_segwit_native": 70617039,
  "bech32_prefix": "tbtg",
  "cashaddr_prefix": null,
-  "slip44": 156,
+  "slip44": 1,
  "segwit": true,
  "decred": false,
  "fork_id": 79,
--- a/common/defs/bitcoin/smartcash_testnet.json
+++ b/common/defs/bitcoin/smartcash_testnet.json
@ -21,7 +21,7 @@
  "xpub_magic_multisig_segwit_native": null,
  "bech32_prefix": null,
  "cashaddr_prefix": null,
-  "slip44": 224,
+  "slip44": 1,
  "segwit": false,
  "decred": false,
  "fork_id": null,
--- a/core/.changelog.d/noissue.security.2
+++ b/core/.changelog.d/noissue.security.2
@ -0,0 +1 @@
+Ensure that all testnet coins use SLIP-44 coin type 1.
--- a/core/src/apps/common/coininfo.py
+++ b/core/src/apps/common/coininfo.py
@ -390,7 +390,7 @@ def by_name(name: str) -> CoinInfo:
                xpub_magic_multisig_segwit_native=0x043587cf,
                bech32_prefix="tbtg",
                cashaddr_prefix=None,
-                slip44=156,
+                slip44=1,
                segwit=True,
                fork_id=79,
                force_bip143=True,
@ -1482,7 +1482,7 @@ def by_name(name: str) -> CoinInfo:
                xpub_magic_multisig_segwit_native=None,
                bech32_prefix=None,
                cashaddr_prefix=None,
-                slip44=224,
+                slip44=1,
                segwit=False,
                fork_id=None,
                force_bip143=False,
--- a/legacy/firmware/.changelog.d/noissue.security.2
+++ b/legacy/firmware/.changelog.d/noissue.security.2
@ -0,0 +1 @@
+Ensure that all testnet coins use SLIP-44 coin type 1.
				`@ -0,0 +1 @@`
				`Ensure that all testnet coins use SLIP-44 coin type 1.`