arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-24 07:18:09 +00:00
Code Issues Releases Wiki Activity

feat(legacy): Show "signature is valid" dialog when VerifyMessage succeeds.

Browse Source
This commit is contained in:
Andrew Kozlik 2022-02-04 18:35:21 +01:00 committed by Andrew Kozlik
parent bf2baf798f
commit b5c9f573b2
4 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
legacy/firmware/.changelog.d/1880.added Normal file
View File

@ -0,0 +1 @@
Show "signature is valid" dialog when VerifyMessage succeeds.

8
legacy/firmware/fsm_msg_coin.h
View File

@ -343,6 +343,14 @@ void fsm_msgVerifyMessage(const VerifyMessage *msg) {
return;
}
layoutDialogSwipe(&bmp_icon_ok, NULL, _("Continue"), NULL, NULL,
_("The signature is valid."), NULL, NULL, NULL, NULL);
if (!protectButton(ButtonRequestType_ButtonRequest_Other, true)) {
fsm_sendFailure(FailureType_Failure_ActionCancelled, NULL);
layoutHome();
return;
}
fsm_sendSuccess(_("Message verified"));
} else {
fsm_sendFailure(FailureType_Failure_DataError, _("Invalid signature"));

8
legacy/firmware/fsm_msg_ethereum.h
View File

@ -204,6 +204,14 @@ void fsm_msgEthereumVerifyMessage(const EthereumVerifyMessage *msg) {
return;
}
layoutDialogSwipe(&bmp_icon_ok, NULL, _("Continue"), NULL, NULL,
_("The signature is valid."), NULL, NULL, NULL, NULL);
if (!protectButton(ButtonRequestType_ButtonRequest_Other, true)) {
fsm_sendFailure(FailureType_Failure_ActionCancelled, NULL);
layoutHome();
return;
}
fsm_sendSuccess(_("Message verified"));
layoutHome();

1
tests/device_tests/test_protection_levels.py
View File

@ -300,6 +300,7 @@ def test_verify_message_t1(client: Client):
with client:
client.set_expected_responses(
[
messages.ButtonRequest,
messages.ButtonRequest,
messages.ButtonRequest,
messages.Success,