arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-06-26 01:42:34 +00:00
Code Issues Releases Wiki Activity

fix(core/debug): separate buffer for debuglink to prevent BufferLock deadlocks

Browse Source 
[no changelog]
This commit is contained in:
matejcik 2022-10-19 11:43:56 +02:00 committed by matejcik
parent d0f1095842
commit ac6936d65d
2 changed files with 57 additions and 79 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/src/trezor/wire/__init__.py
View File

@ -136,6 +136,10 @@ PROTOBUF_BUFFER_SIZE = 8192
WIRE_BUFFER = bytearray(PROTOBUF_BUFFER_SIZE) WIRE_BUFFER = bytearray(PROTOBUF_BUFFER_SIZE)
if __debug__:
PROTOBUF_BUFFER_SIZE_DEBUG = 1024
WIRE_BUFFER_DEBUG = bytearray(PROTOBUF_BUFFER_SIZE_DEBUG)
class Context: class Context:
def __init__(self, iface: WireInterface, sid: int, buffer: bytearray) -> None: def __init__(self, iface: WireInterface, sid: int, buffer: bytearray) -> None:
@ -381,7 +385,12 @@ async def _handle_single_message(
async def handle_session( async def handle_session(
iface: WireInterface, session_id: int, is_debug_session: bool = False iface: WireInterface, session_id: int, is_debug_session: bool = False
) -> None: ) -> None:
ctx = Context(iface, session_id, WIRE_BUFFER) if __debug__ and is_debug_session:
ctx_buffer = WIRE_BUFFER_DEBUG
else:
ctx_buffer = WIRE_BUFFER
ctx = Context(iface, session_id, ctx_buffer)
next_msg: codec_v1.Message | None = None next_msg: codec_v1.Message | None = None
if __debug__ and is_debug_session: if __debug__ and is_debug_session:

31
core/src/trezor/wire/codec_v1.py
View File

@ -5,7 +5,6 @@ from typing import TYPE_CHECKING
from trezor import io, loop, utils from trezor import io, loop, utils
if TYPE_CHECKING: if TYPE_CHECKING:
from typing import Any
from trezorio import WireInterface from trezorio import WireInterface
_REP_LEN = const(64) _REP_LEN = const(64)
@ -19,34 +18,6 @@ _REP_CONT_DATA = const(1) # offset of data in the continuation report
SESSION_ID = const(0) SESSION_ID = const(0)
INVALID_TYPE = const(-1) INVALID_TYPE = const(-1)
# The wire buffer is shared between the main wire interface and debuglink
# (see __init__.py). There's no obvious guarantee that both interfaces won't
# use it at the same time, thus we check this at runtime in debug builds.
if __debug__:
class BufferLock: # type: ignore [Class declaration "BufferLock" is obscured by a declaration of the same name]
def __init__(self) -> None:
self.in_use = False
def __enter__(self) -> None:
assert not self.in_use, "global buffer already used by another context"
self.in_use = True
def __exit__(self, exc_type: Any, value: Any, traceback: Any) -> None:
self.in_use = False
else:
class BufferLock:
def __enter__(self) -> None:
pass
def __exit__(self, exc_type: Any, value: Any, traceback: Any) -> None:
pass
buffer_lock = BufferLock()
class CodecError(Exception): class CodecError(Exception):
pass pass
@ -71,7 +42,6 @@ async def read_message(iface: WireInterface, buffer: utils.BufferType) -> Messag
read_and_throw_away = False read_and_throw_away = False
with buffer_lock:
if msize > len(buffer): if msize > len(buffer):
# allocate a new buffer to fit the message # allocate a new buffer to fit the message
try: try:
@ -107,7 +77,6 @@ async def read_message(iface: WireInterface, buffer: utils.BufferType) -> Messag
async def write_message(iface: WireInterface, mtype: int, mdata: bytes) -> None: async def write_message(iface: WireInterface, mtype: int, mdata: bytes) -> None:
write = loop.wait(iface.iface_num() | io.POLL_WRITE) write = loop.wait(iface.iface_num() | io.POLL_WRITE)
with buffer_lock:
# gather data from msg # gather data from msg
msize = len(mdata) msize = len(mdata)