1
0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-22 22:38:08 +00:00

transport_hid: refcount for hid handle

This commit is contained in:
Jan Pochyla 2017-09-05 17:10:58 +02:00
parent dffa93bee3
commit ac0184413d

View File

@ -30,22 +30,47 @@ DEV_TREZOR2 = (0x1209, 0x53c1)
DEV_TREZOR2_BL = (0x1209, 0x53c0) DEV_TREZOR2_BL = (0x1209, 0x53c0)
class HidHandle(object):
def __init__(self, path):
self.path = path
self.count = 0
self.handle = None
def open(self):
if self.count == 0:
self.handle = hid.device()
self.handle.open_path(self.path)
self.handle.set_nonblocking(True)
self.count += 1
def close(self):
if self.count == 1:
self.handle.close()
if self.count > 0:
self.count -= 1
class HidTransport(Transport): class HidTransport(Transport):
''' '''
HidTransport implements transport over USB HID interface. HidTransport implements transport over USB HID interface.
''' '''
def __init__(self, device, protocol=None): def __init__(self, device, protocol=None, hid_handle=None):
super(HidTransport, self).__init__() super(HidTransport, self).__init__()
if hid_handle is None:
hid_handle = HidHandle(device['path'])
if protocol is None: if protocol is None:
if is_trezor2(device): if is_trezor2(device):
protocol = ProtocolV2() protocol = ProtocolV2()
else: else:
protocol = ProtocolV1() protocol = ProtocolV1()
self.device = device self.device = device
self.protocol = protocol self.protocol = protocol
self.hid = None self.hid = hid_handle
self.hid_version = None self.hid_version = None
def __str__(self): def __str__(self):
@ -76,9 +101,8 @@ class HidTransport(Transport):
def find_debug(self): def find_debug(self):
if isinstance(self.protocol, ProtocolV2): if isinstance(self.protocol, ProtocolV2):
# For v2 protocol, lets use the same HID interface, but with a different session # For v2 protocol, lets use the same HID interface, but with a different session
debug = HidTransport(self.device, ProtocolV2()) protocol = ProtocolV2()
debug.hid = self.hid debug = HidTransport(self.device, protocol, self.hid)
debug.hid_version = self.hid_version
return debug return debug
if isinstance(self.protocol, ProtocolV1): if isinstance(self.protocol, ProtocolV1):
# For v1 protocol, find debug USB interface for the same serial number # For v1 protocol, find debug USB interface for the same serial number
@ -88,11 +112,7 @@ class HidTransport(Transport):
raise Exception('Debug HID device not found') raise Exception('Debug HID device not found')
def open(self): def open(self):
if self.hid: self.hid.open()
return
self.hid = hid.device()
self.hid.open_path(self.device['path'])
self.hid.set_nonblocking(True)
if is_trezor1(self.device): if is_trezor1(self.device):
self.hid_version = self.probe_hid_version() self.hid_version = self.probe_hid_version()
else: else:
@ -101,11 +121,7 @@ class HidTransport(Transport):
def close(self): def close(self):
self.protocol.session_end(self) self.protocol.session_end(self)
try:
self.hid.close() self.hid.close()
except OSError:
pass # Failing to close the handle is not a problem
self.hid = None
self.hid_version = None self.hid_version = None
def read(self): def read(self):
@ -118,13 +134,13 @@ class HidTransport(Transport):
if len(chunk) != 64: if len(chunk) != 64:
raise Exception('Unexpected chunk size: %d' % len(chunk)) raise Exception('Unexpected chunk size: %d' % len(chunk))
if self.hid_version == 2: if self.hid_version == 2:
self.hid.write(b'\0' + chunk) self.hid.handle.write(b'\0' + chunk)
else: else:
self.hid.write(chunk) self.hid.handle.write(chunk)
def read_chunk(self): def read_chunk(self):
while True: while True:
chunk = self.hid.read(64) chunk = self.hid.handle.read(64)
if chunk: if chunk:
break break
else: else:
@ -134,10 +150,10 @@ class HidTransport(Transport):
return bytearray(chunk) return bytearray(chunk)
def probe_hid_version(self): def probe_hid_version(self):
n = self.hid.write([0, 63] + [0xFF] * 63) n = self.hid.handle.write([0, 63] + [0xFF] * 63)
if n == 65: if n == 65:
return 2 return 2
n = self.hid.write([63] + [0xFF] * 63) n = self.hid.handle.write([63] + [0xFF] * 63)
if n == 64: if n == 64:
return 1 return 1
raise Exception('Unknown HID version') raise Exception('Unknown HID version')