chore(ci): rename UI jobs and make legacy UI a dependency

ci/deploy.yml

@@ -226,7 +226,7 @@ release legacy unix debug deploy:
 
 # UI tests
 
-ui tests core fixtures deploy:
+ui tests fixtures deploy:
   stage: deploy
   variables:
     DEPLOY_PATH: "${DEPLOY_BASE_DIR}/ui_tests/"
@@ -234,6 +234,7 @@ ui tests core fixtures deploy:
   before_script: []  # no poetry
   needs:
     - core device test
+    - legacy device test
   script:
     - echo "Deploying to $DEPLOY_PATH"
     - rsync --delete -va ci/ui_test_records/* "$DEPLOY_PATH"

ci/posttest.yml

@@ -28,13 +28,14 @@ core unix coverage posttest:
     when: always
     expire_in: 1 week
 
-core unix ui changes:
+unix ui changes:
   stage: posttest
   except:
     - master
   <<: *gitlab_caching
   needs:
     - core device test
+    - legacy device test
   script:
     - nix-shell --run "cd tests/ui_tests ; poetry run python reporting/report_master_diff.py"
     - mv tests/ui_tests/reporting/reports/master_diff/ .

ci/test.yml

@@ -405,7 +405,7 @@ crypto test:
 
 # Legacy
 
-legacy test:
+legacy device test:
   stage: test
   <<: *gitlab_caching
   needs:

docs/tests/ui-tests.md

@@ -90,5 +90,5 @@ creates a report where you find which tests were altered, added, or removed rela
 master. This useful for Pull Requests.
 
 This report is available as an artifact on CI as well. You can find it by
-visiting the "core unix ui changes" job in your pipeline - browse the
+visiting the "unix ui changes" job in your pipeline - browse the
 artifacts and open `master_diff/index.html`.