arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-01-03 12:00:59 +00:00
Code Issues Releases Wiki Activity

fix(tests): more robust master diff handling

Browse Source 
fixes #2799
This commit is contained in:
matejcik 2023-02-10 11:54:10 +01:00 committed by Martin Milata
parent 034947985a
commit 9add2b0027
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/ui_tests/reporting/download.py
View File

@ -18,7 +18,6 @@ def fetch_recorded(hash: str, path: Path) -> None:
zip_dest = path / "recorded.zip"
try:
print("downloading", zip_src)
urllib.request.urlretrieve(zip_src, zip_dest)
except urllib.error.HTTPError:
raise RuntimeError(f"No such recorded collection was found on '{zip_src}'.")

15
tests/ui_tests/reporting/master_diff.py
View File

@ -234,14 +234,21 @@ def create_reports() -> None:
added(path, test_name)
for test_name, (master_hash, current_hash) in diff_tests.items():
with tmpdir() as master_screens:
with tmpdir() as master_root:
master_screens = master_root / "downloaded"
master_screens.mkdir()
try:
download.fetch_recorded(master_hash, master_screens)
except RuntimeError as e:
print("WARNING:", e)
current_screens = SCREENS_DIR / test_name / "actual"
if not current_screens.exists():
raise RuntimeError(
"Folder does not exist, did the test run?", current_screens
)
print("WARNING: Folder does not exist, did the test run?")
print(current_screens)
current_screens = master_root / "empty_current_screens"
current_screens.mkdir()
diff(
master_screens,
current_screens,