arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-18 12:28:09 +00:00
Code Issues Releases Wiki Activity

src/apps/ethereum: support full 32bit chain_id

Browse Source 
* remove chain_id restriction to support full 32bit chain_id.
 * for chain_id > MAX_CHAIN_ID(2147483630) case, simply return v signature parity.
 * see also https://github.com/trezor/trezor-mcu/pull/399
This commit is contained in:
hackyminer 2018-08-14 23:35:02 +09:00 committed by Pavol Rusnak
parent cadc6786f0
commit 9a5c38dad4
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/apps/ethereum/sign_tx.py
View File

@ -138,7 +138,9 @@ async def send_signature(ctx, msg: EthereumSignTx, digest):
req = EthereumTxRequest() req = EthereumTxRequest()
req.signature_v = signature[0] req.signature_v = signature[0]
if msg.chain_id: if msg.chain_id > MAX_CHAIN_ID:
req.signature_v -= 27
elif msg.chain_id:
req.signature_v += 2 * msg.chain_id + 8 req.signature_v += 2 * msg.chain_id + 8
req.signature_r = signature[1:33] req.signature_r = signature[1:33]
@ -151,7 +153,7 @@ def check(msg: EthereumSignTx):
if msg.tx_type not in [1, 6, None]: if msg.tx_type not in [1, 6, None]:
raise wire.DataError("tx_type out of bounds") raise wire.DataError("tx_type out of bounds")
if msg.chain_id < 0 or msg.chain_id > MAX_CHAIN_ID: if msg.chain_id < 0:
raise wire.DataError("chain_id out of bounds") raise wire.DataError("chain_id out of bounds")
if msg.data_length > 0: if msg.data_length > 0: