arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-11-27 01:48:17 +00:00
Code Issues Releases Wiki Activity

tests: Check PIN properly in test_msg_changepin.

Browse Source
This commit is contained in:
Andrew Kozlik 2019-02-14 19:16:43 +01:00
parent d5c2636f0d
commit 9a1e14d974
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
trezorlib/tests/device_tests/test_msg_changepin.py
View File

@ -58,7 +58,7 @@ class TestMsgChangepin(TrezorTest):
assert features.pin_protection is True assert features.pin_protection is True
# Check that the PIN is correct # Check that the PIN is correct
assert self.client.debug.read_pin()[0] == self.pin6 self.check_pin(self.pin6)
def test_change_pin(self): def test_change_pin(self):
self.setup_mnemonic_pin_passphrase() self.setup_mnemonic_pin_passphrase()
@ -71,7 +71,7 @@ class TestMsgChangepin(TrezorTest):
self.client.call_raw(proto.Cancel()) self.client.call_raw(proto.Cancel())
# Check current PIN value # Check current PIN value
assert self.client.debug.read_pin()[0] == self.pin4 self.check_pin(self.pin4)
# Let's change PIN # Let's change PIN
ret = self.client.call_raw(proto.ChangePin()) ret = self.client.call_raw(proto.ChangePin())
@ -104,7 +104,7 @@ class TestMsgChangepin(TrezorTest):
assert features.pin_protection is True assert features.pin_protection is True
# Check that the PIN is correct # Check that the PIN is correct
assert self.client.debug.read_pin()[0] == self.pin6 self.check_pin(self.pin6)
def test_remove_pin(self): def test_remove_pin(self):
self.setup_mnemonic_pin_passphrase() self.setup_mnemonic_pin_passphrase()
@ -208,4 +208,12 @@ class TestMsgChangepin(TrezorTest):
# Check that there's still old PIN protection # Check that there's still old PIN protection
features = self.client.call_raw(proto.Initialize()) features = self.client.call_raw(proto.Initialize())
assert features.pin_protection is True assert features.pin_protection is True
assert self.client.debug.read_pin()[0] == self.pin4 self.check_pin(self.pin4)
def check_pin(self, pin):
self.client.clear_session()
ret = self.client.call_raw(proto.Ping(pin_protection=True))
assert isinstance(ret, proto.PinMatrixRequest)
pin_encoded = self.client.debug.encode_pin(pin)
ret = self.client.call_raw(proto.PinMatrixAck(pin=pin_encoded))
assert isinstance(ret, proto.Success)