arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-11-26 17:38:39 +00:00
Code Issues Releases Wiki Activity

embed: fix 3 TODO items

Browse Source
This commit is contained in:
Pavol Rusnak 2018-02-12 14:51:41 +01:00
parent 8a409bd99a
commit 936f0e3e26
No known key found for this signature in database
GPG Key ID: 91F3B339B9A02A3D
3 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
embed/bootloader/messages.c
View File

@ -252,8 +252,6 @@ static void send_msg_features(uint8_t iface_num, const vendor_header * const vhd
} else {
MSG_SEND_ASSIGN_VALUE(firmware_present, false);
}
// TODO: pass info about installed firmware (vendor, version, etc.)
MSG_SEND(Features);
}

5
embed/extmod/modtrezorconfig/norcow.c
View File

@ -196,10 +196,7 @@ static void compact()
// copy the last item
uint32_t posw;
r = write_item(norcow_next_sector, offsetw, k, v, l, &posw);
if (sectrue != r) {
// TODO: error
}
ensure(write_item(norcow_next_sector, offsetw, k, v, l, &posw), "compaction write failed");
offsetw = posw;
}

3
embed/trezorhal/image.h
View File

@ -16,8 +16,7 @@
#define BOOTLOADER_IMAGE_MAXSIZE (1 * IMAGE_CHUNK_SIZE)
#define FIRMWARE_IMAGE_MAGIC 0x465A5254 // TRZF
#define FIRMWARE_IMAGE_MAXSIZE (6 * IMAGE_CHUNK_SIZE)
// TODO: change above limitation to 13 blocks after fixing writing to non-continuous area
#define FIRMWARE_IMAGE_MAXSIZE (13 * IMAGE_CHUNK_SIZE)
typedef struct {
uint32_t magic;