fix(crypto): clarify incorrect base58.c code comment

2 years ago · 91dd21b561
parent 38c526719c
commit 91dd21b561
1 changed files with 5 additions and 1 deletions
--- a/crypto/monero/base58.c
+++ b/crypto/monero/base58.c
@ -119,7 +119,11 @@ bool decode_block(const char* block, size_t size, char* res)
 			return false; // Overflow

 		res_num = tmp;
-		order *= alphabet_size; // Never overflows, 58^10 < 2^64
+		// The original code comment for the order multiplication says
+		// "Never overflows, 58^10 < 2^64"
+		// This is incorrect since it overflows on the 11th iteration
+		// However, there is no negative impact since the result is unused
+		order *= alphabet_size;
 	}

 	if ((size_t)res_size < full_block_size && (UINT64_C(1) << (8 * res_size)) <= res_num)