arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-08-02 11:58:32 +00:00
Code Issues Releases Wiki Activity

ci(core): don't run UI tests on both THP & non-THP builds (per model)

Browse Source 
Otherwise, the results will get "mixed" in the UI report.

[no changelog]
This commit is contained in:
Roman Zeyde 2025-07-11 20:48:07 +03:00 committed by M1nd3r
parent 7bb5a1135b
commit 8fbd2d3d6b
1 changed files with 12 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
.github/workflows/core.yml vendored
View File

@ -386,7 +386,7 @@ jobs:
# See artifacts for a comprehensive report of UI. # See artifacts for a comprehensive report of UI.
# See [docs/tests/ui-tests](../tests/ui-tests.md) for more info. # See [docs/tests/ui-tests](../tests/ui-tests.md) for more info.
core_device_test: core_device_test:
name: Device tests (${{ matrix.model }}, ${{ matrix.coins }}, ${{ matrix.asan }}, ${{ matrix.lang }}${{ matrix.protocol=='v2' && ', THP' || ''}}) name: Device tests (${{ matrix.model }}, ${{ matrix.coins }}, ${{ matrix.asan }}, ${{ matrix.lang }})
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: needs:
- param - param
@ -398,13 +398,6 @@ jobs:
coins: [universal, btconly] coins: [universal, btconly]
asan: ${{ fromJSON(needs.param.outputs.asan) }} asan: ${{ fromJSON(needs.param.outputs.asan) }}
lang: ${{ fromJSON(needs.param.outputs.test_lang) }} lang: ${{ fromJSON(needs.param.outputs.test_lang) }}
protocol: [v1]
include:
- model: T2T1
coins: universal
asan: noasan
lang: en
protocol: v2
env: env:
TREZOR_PROFILING: ${{ matrix.asan == 'noasan' && '1' || '0' }} TREZOR_PROFILING: ${{ matrix.asan == 'noasan' && '1' || '0' }}
TREZOR_MODEL: ${{ matrix.model }} TREZOR_MODEL: ${{ matrix.model }}
@ -413,7 +406,7 @@ jobs:
ACTIONS_DO_UI_TEST: ${{ matrix.coins == 'universal' && matrix.asan == 'noasan' }} ACTIONS_DO_UI_TEST: ${{ matrix.coins == 'universal' && matrix.asan == 'noasan' }}
TEST_LANG: ${{ matrix.lang }} TEST_LANG: ${{ matrix.lang }}
TESTOPTS: "--durations 50 --session-timeout 1800" # 30m pytest global timeout TESTOPTS: "--durations 50 --session-timeout 1800" # 30m pytest global timeout
THP: ${{ matrix.protocol == 'v2' && '1' || '0'}} PROTOCOL: ${{ matrix.model == 'T3W1' && 'v2' || 'v1'}}
timeout-minutes: 40 timeout-minutes: 40
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
@ -421,7 +414,7 @@ jobs:
submodules: recursive submodules: recursive
- uses: actions/download-artifact@v4 - uses: actions/download-artifact@v4
with: with:
name: core-emu-${{ matrix.model }}-${{ matrix.coins }}-debuglink-${{ matrix.asan }}-protocol_${{ matrix.protocol }} name: core-emu-${{ matrix.model }}-${{ matrix.coins }}-debuglink-${{ matrix.asan }}-protocol_${{ env.PROTOCOL }}
path: core/build path: core/build
- run: chmod +x core/build/unix/trezor-emu-core* - run: chmod +x core/build/unix/trezor-emu-core*
- uses: ./.github/actions/environment - uses: ./.github/actions/environment
@ -430,7 +423,7 @@ jobs:
if: failure() if: failure()
- uses: actions/upload-artifact@v4 - uses: actions/upload-artifact@v4
with: with:
name: core-test-device-${{ matrix.model }}-${{ matrix.coins }}-${{ matrix.lang }}-${{ matrix.asan }}-protocol_${{ matrix.protocol }} name: core-test-device-${{ matrix.model }}-${{ matrix.coins }}-${{ matrix.lang }}-${{ matrix.asan }}-protocol_${{ env.PROTOCOL }}
path: tests/trezor*.log path: tests/trezor*.log
retention-days: 7 retention-days: 7
if: always() if: always()
@ -446,7 +439,7 @@ jobs:
# Click tests - UI. # Click tests - UI.
# See [docs/tests/click-tests](../tests/click-tests.md) for more info. # See [docs/tests/click-tests](../tests/click-tests.md) for more info.
core_click_test: core_click_test:
name: Click tests (${{ matrix.model }}, ${{ matrix.asan }}, ${{ matrix.lang }}${{ matrix.protocol=='v2' && ', THP' || ''}}) name: Click tests (${{ matrix.model }}, ${{ matrix.asan }}, ${{ matrix.lang }})
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: needs:
- param - param
@ -458,24 +451,19 @@ jobs:
model: [T2T1, T3B1, T3T1, T3W1] model: [T2T1, T3B1, T3T1, T3W1]
asan: ${{ fromJSON(needs.param.outputs.asan) }} asan: ${{ fromJSON(needs.param.outputs.asan) }}
lang: ${{ fromJSON(needs.param.outputs.test_lang) }} lang: ${{ fromJSON(needs.param.outputs.test_lang) }}
protocol: [v1]
include:
- model: T2T1
asan: noasan
lang: en
protocol: v2
env: env:
TREZOR_PROFILING: ${{ matrix.asan == 'noasan' && '1' || '0' }} TREZOR_PROFILING: ${{ matrix.asan == 'noasan' && '1' || '0' }}
# MULTICORE: 4 # more could interfere with other jobs # MULTICORE: 4 # more could interfere with other jobs
PYTEST_TIMEOUT: 400 PYTEST_TIMEOUT: 400
TEST_LANG: ${{ matrix.lang }} TEST_LANG: ${{ matrix.lang }}
PROTOCOL: ${{ matrix.model == 'T3W1' && 'v2' || 'v1'}}
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
with: with:
submodules: recursive submodules: recursive
- uses: actions/download-artifact@v4 - uses: actions/download-artifact@v4
with: with:
name: core-emu-${{ matrix.model }}-universal-debuglink-${{ matrix.asan }}-protocol_${{matrix.protocol}} name: core-emu-${{ matrix.model }}-universal-debuglink-${{ matrix.asan }}-protocol_${{env.PROTOCOL}}
path: core/build path: core/build
- run: chmod +x core/build/unix/trezor-emu-core* - run: chmod +x core/build/unix/trezor-emu-core*
- uses: ./.github/actions/environment - uses: ./.github/actions/environment
@ -485,7 +473,7 @@ jobs:
if: ${{ matrix.asan == 'asan' }} if: ${{ matrix.asan == 'asan' }}
- uses: actions/upload-artifact@v4 - uses: actions/upload-artifact@v4
with: with:
name: core-test-click-${{ matrix.model }}-${{ matrix.lang }}-${{ matrix.asan }}-protocol_${{matrix.protocol}} name: core-test-click-${{ matrix.model }}-${{ matrix.lang }}-${{ matrix.asan }}-protocol_${{env.PROTOCOL}}
path: tests/trezor*.log path: tests/trezor*.log
retention-days: 7 retention-days: 7
if: always() if: always()
@ -540,7 +528,7 @@ jobs:
# Persistence tests - UI. # Persistence tests - UI.
core_persistence_test: core_persistence_test:
name: Persistence tests (${{ matrix.model }}, ${{ matrix.asan }}${{ matrix.protocol=='v2' && ', THP' || ''}}) name: Persistence tests (${{ matrix.model }}, ${{ matrix.asan }})
runs-on: ubuntu-latest runs-on: ubuntu-latest
needs: needs:
- param - param
@ -551,21 +539,17 @@ jobs:
matrix: matrix:
model: [T2T1, T3B1, T3T1, T3W1] model: [T2T1, T3B1, T3T1, T3W1]
asan: ${{ fromJSON(needs.param.outputs.asan) }} asan: ${{ fromJSON(needs.param.outputs.asan) }}
protocol: [v1]
include:
- model: T2T1
asan: noasan
protocol: v2
env: env:
TREZOR_PROFILING: ${{ matrix.asan == 'noasan' && '1' || '0' }} TREZOR_PROFILING: ${{ matrix.asan == 'noasan' && '1' || '0' }}
PYTEST_TIMEOUT: 400 PYTEST_TIMEOUT: 400
PROTOCOL: ${{ matrix.model == 'T3W1' && 'v2' || 'v1'}}
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
with: with:
submodules: recursive submodules: recursive
- uses: actions/download-artifact@v4 - uses: actions/download-artifact@v4
with: with:
name: core-emu-${{ matrix.model }}-universal-debuglink-${{ matrix.asan }}-protocol_${{matrix.protocol}} name: core-emu-${{ matrix.model }}-universal-debuglink-${{ matrix.asan }}-protocol_${{env.PROTOCOL}}
path: core/build path: core/build
- run: chmod +x core/build/unix/trezor-emu-core* - run: chmod +x core/build/unix/trezor-emu-core*
- uses: ./.github/actions/environment - uses: ./.github/actions/environment
@ -583,7 +567,7 @@ jobs:
- uses: ./.github/actions/upload-coverage - uses: ./.github/actions/upload-coverage
- uses: actions/upload-artifact@v4 - uses: actions/upload-artifact@v4
with: with:
name: core-test-persistence-${{ matrix.model }}-${{ matrix.asan }}-protocol_${{matrix.protocol}} name: core-test-persistence-${{ matrix.model }}-${{ matrix.asan }}-protocol_${{env.PROTOCOL}}
path: | path: |
tests/trezor*.log tests/trezor*.log
retention-days: 7 retention-days: 7