tests: add partial pylint support

Makefile

@@ -47,6 +47,9 @@ test: ## run unit tests
 testpy: ## run selected unit tests from python-trezor
 	cd tests ; ./run_tests_python_trezor.sh
 
+pylint: ## run pylint on application sources
+	pylint --rcfile=pylint.rc -E $(shell find src -name *.py)
+
 ## build commands:
 
 build: build_boardloader build_bootloader build_firmware build_unix build_cross ## build all

mocks/micropython.py

@@ -1,5 +1,5 @@
 def const(c):
-    pass
+    return c
 
 def mem_info(verbose=None):
     pass

mocks/ubinascii.py

@@ -1,11 +1,14 @@
 def hexlify(data, sep=None):
-    pass
+    return 0
 
 def unhexlify(data):
-    pass
+    return 0
 
 def a2b_base64(data):
-    pass
+    return 0
 
 def b2a_base64(data):
-    pass
+    return 0
+
+def crc32(data, crc=None):
+    return 0

mocks/uctypes.py

@@ -0,0 +1,37 @@
+ARRAY = 0
+NATIVE = 0
+LITTLE_ENDIAN = 0
+BIG_ENDIAN = 0
+VOID = 0
+UINT8 = 0
+INT8 = 0
+UINT16 = 0
+INT16 = 0
+UINT32 = 0
+INT32 = 0
+UINT64 = 0
+INT64 = 0
+BFUINT8 = 0
+BFINT8 = 0
+BFUINT16 = 0
+BFINT16 = 0
+BFUINT32 = 0
+BFINT32 = 0
+BF_POS = 0
+BF_LEN = 0
+FLOAT32 = 0
+
+def struct(addr, descriptor, layout_type=NATIVE):
+    return 0
+
+def sizeof(struct):
+    return 0
+
+def addressof(obj):
+    return 0
+
+def bytes_at(addr, size):
+    return 0
+
+def bytearray_at(addr, size):
+    return 0

mocks/ustruct.py

@@ -1,14 +1,14 @@
 def calcsize(fmt):
-    pass
+    return 0
 
 def pack(fmt, *args):
-    pass
+    return 0
 
 def pack_info(fmt, buffer, offset, *args):
-    pass
+    return 0
 
 def unpack(fmt, data):
-    pass
+    return 0
 
 def unpack_from(fmt, data, offset=0):
-    pass
+    return 0

mocks/utime.py

@@ -1,11 +1,11 @@
 def localtime(secs=None):
-    pass
+    return 0
 
 def ticks_ms():
-    pass
+    return 0
 
 def mktime():
-    pass
+    return 0
 
 def sleep(seconds):
     pass
@@ -17,16 +17,19 @@ def sleep_us(us):
     pass
 
 def ticks_ms():
-    pass
+    return 0
 
 def ticks_us():
-    pass
+    return 0
 
 def ticks_cpu():
-    pass
+    return 0
+
+def ticks_add(ticks_in, delta_in):
+    return 0
 
 def ticks_diff(old, new):
-    pass
+    return 0
 
 def time():
-    pass
+    return 0

pylint.rc

@@ -0,0 +1,2 @@
+[MASTER]
+init-hook='sys.path.insert(0, "mocks")'

src/apps/fido_u2f/__init__.py

@@ -1,3 +1,5 @@
+from micropython import const
+
 import uctypes
 import ustruct
 import utime

src/main.py

@@ -1,3 +1,5 @@
+from micropython import const
+
 import trezor.main
 from trezor import msg
 from trezor import ui

src/trezor/messages/Address.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class Address(p.MessageType):

src/trezor/messages/ApplySettings.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class ApplySettings(p.MessageType):

src/trezor/messages/ButtonAck.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class ButtonAck(p.MessageType):

src/trezor/messages/ButtonRequest.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class ButtonRequest(p.MessageType):

src/trezor/messages/ButtonRequestType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 Other = const(1)
 FeeOverThreshold = const(2)
 ConfirmOutput = const(3)

src/trezor/messages/Cancel.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class Cancel(p.MessageType):

src/trezor/messages/ChangePin.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class ChangePin(p.MessageType):

src/trezor/messages/CipherKeyValue.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class CipherKeyValue(p.MessageType):

src/trezor/messages/CipheredKeyValue.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class CipheredKeyValue(p.MessageType):

src/trezor/messages/ClearSession.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class ClearSession(p.MessageType):

src/trezor/messages/CoinType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class CoinType(p.MessageType):

src/trezor/messages/DebugLinkDecision.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DebugLinkDecision(p.MessageType):

src/trezor/messages/DebugLinkFlashErase.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DebugLinkFlashErase(p.MessageType):

src/trezor/messages/DebugLinkGetState.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DebugLinkGetState(p.MessageType):

src/trezor/messages/DebugLinkLog.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DebugLinkLog(p.MessageType):

src/trezor/messages/DebugLinkMemory.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DebugLinkMemory(p.MessageType):

src/trezor/messages/DebugLinkMemoryRead.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DebugLinkMemoryRead(p.MessageType):

src/trezor/messages/DebugLinkMemoryWrite.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DebugLinkMemoryWrite(p.MessageType):

src/trezor/messages/DebugLinkState.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .HDNodeType import HDNodeType
 

src/trezor/messages/DebugLinkStop.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DebugLinkStop(p.MessageType):

src/trezor/messages/DecryptMessage.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DecryptMessage(p.MessageType):

src/trezor/messages/DecryptedMessage.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class DecryptedMessage(p.MessageType):

src/trezor/messages/ECDHSessionKey.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class ECDHSessionKey(p.MessageType):

src/trezor/messages/EncryptMessage.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EncryptMessage(p.MessageType):

src/trezor/messages/EncryptedMessage.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EncryptedMessage(p.MessageType):

src/trezor/messages/Entropy.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class Entropy(p.MessageType):

src/trezor/messages/EntropyAck.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EntropyAck(p.MessageType):

src/trezor/messages/EntropyRequest.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EntropyRequest(p.MessageType):

src/trezor/messages/EstimateTxSize.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EstimateTxSize(p.MessageType):

src/trezor/messages/EthereumAddress.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EthereumAddress(p.MessageType):

src/trezor/messages/EthereumGetAddress.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EthereumGetAddress(p.MessageType):

src/trezor/messages/EthereumSignTx.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EthereumSignTx(p.MessageType):

src/trezor/messages/EthereumTxAck.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EthereumTxAck(p.MessageType):

src/trezor/messages/EthereumTxRequest.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class EthereumTxRequest(p.MessageType):

src/trezor/messages/Failure.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class Failure(p.MessageType):

src/trezor/messages/FailureType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 UnexpectedMessage = const(1)
 ButtonExpected = const(2)
 SyntaxError = const(3)

src/trezor/messages/Features.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .CoinType import CoinType
 

src/trezor/messages/FirmwareErase.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class FirmwareErase(p.MessageType):

src/trezor/messages/FirmwareRequest.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class FirmwareRequest(p.MessageType):

src/trezor/messages/FirmwareUpload.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class FirmwareUpload(p.MessageType):

src/trezor/messages/GetAddress.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .MultisigRedeemScriptType import MultisigRedeemScriptType
 

src/trezor/messages/GetECDHSessionKey.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .IdentityType import IdentityType
 

src/trezor/messages/GetEntropy.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class GetEntropy(p.MessageType):

src/trezor/messages/GetFeatures.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class GetFeatures(p.MessageType):

src/trezor/messages/GetPublicKey.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class GetPublicKey(p.MessageType):

src/trezor/messages/HDNodePathType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .HDNodeType import HDNodeType
 

src/trezor/messages/HDNodeType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class HDNodeType(p.MessageType):

src/trezor/messages/IdentityType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class IdentityType(p.MessageType):

src/trezor/messages/Initialize.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class Initialize(p.MessageType):

src/trezor/messages/InputScriptType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 SPENDADDRESS = const(0)
 SPENDMULTISIG = const(1)
 EXTERNAL = const(2)

src/trezor/messages/LoadDevice.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .HDNodeType import HDNodeType
 

src/trezor/messages/MessageSignature.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class MessageSignature(p.MessageType):

src/trezor/messages/MessageType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 Initialize = const(0)
 Ping = const(1)
 Success = const(2)

src/trezor/messages/MultisigRedeemScriptType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .HDNodePathType import HDNodePathType
 

src/trezor/messages/OutputScriptType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 PAYTOADDRESS = const(0)
 PAYTOSCRIPTHASH = const(1)
 PAYTOMULTISIG = const(2)

src/trezor/messages/PassphraseAck.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class PassphraseAck(p.MessageType):

src/trezor/messages/PassphraseRequest.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class PassphraseRequest(p.MessageType):

src/trezor/messages/PinMatrixAck.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class PinMatrixAck(p.MessageType):

src/trezor/messages/PinMatrixRequest.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class PinMatrixRequest(p.MessageType):

src/trezor/messages/PinMatrixRequestType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 Current = const(1)
 NewFirst = const(2)
 NewSecond = const(3)

src/trezor/messages/Ping.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class Ping(p.MessageType):

src/trezor/messages/PublicKey.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .HDNodeType import HDNodeType
 

src/trezor/messages/RecoveryDevice.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class RecoveryDevice(p.MessageType):

src/trezor/messages/RecoveryDeviceType.py

@@ -1,3 +1,5 @@
 # Automatically generated by pb2py
+from micropython import const
+
 ScrambledWords = const(0)
 Matrix = const(1)

src/trezor/messages/RequestType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 TXINPUT = const(0)
 TXOUTPUT = const(1)
 TXMETA = const(2)

src/trezor/messages/ResetDevice.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class ResetDevice(p.MessageType):

src/trezor/messages/SetU2FCounter.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class SetU2FCounter(p.MessageType):

src/trezor/messages/SignIdentity.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .IdentityType import IdentityType
 

src/trezor/messages/SignMessage.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class SignMessage(p.MessageType):

src/trezor/messages/SignTx.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class SignTx(p.MessageType):

src/trezor/messages/SignedIdentity.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class SignedIdentity(p.MessageType):

src/trezor/messages/SimpleSignTx.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .TxInputType import TxInputType
 from .TxOutputType import TxOutputType

src/trezor/messages/Storage.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .HDNodeType import HDNodeType
 

src/trezor/messages/Success.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class Success(p.MessageType):

src/trezor/messages/TransactionType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .TxInputType import TxInputType
 from .TxOutputBinType import TxOutputBinType

src/trezor/messages/TxAck.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .TransactionType import TransactionType
 

src/trezor/messages/TxInputType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .MultisigRedeemScriptType import MultisigRedeemScriptType
 

src/trezor/messages/TxOutputBinType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class TxOutputBinType(p.MessageType):

src/trezor/messages/TxOutputType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .MultisigRedeemScriptType import MultisigRedeemScriptType
 

src/trezor/messages/TxRequest.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 from .TxRequestDetailsType import TxRequestDetailsType
 from .TxRequestSerializedType import TxRequestSerializedType

src/trezor/messages/TxRequestDetailsType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class TxRequestDetailsType(p.MessageType):

src/trezor/messages/TxRequestSerializedType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class TxRequestSerializedType(p.MessageType):

src/trezor/messages/TxSize.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class TxSize(p.MessageType):

src/trezor/messages/VerifyMessage.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class VerifyMessage(p.MessageType):

src/trezor/messages/WipeDevice.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class WipeDevice(p.MessageType):

src/trezor/messages/WordAck.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class WordAck(p.MessageType):

src/trezor/messages/WordRequest.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 import protobuf as p
 
 class WordRequest(p.MessageType):

src/trezor/messages/WordRequestType.py

@@ -1,4 +1,6 @@
 # Automatically generated by pb2py
+from micropython import const
+
 Plain = const(0)
 Matrix9 = const(1)
 Matrix6 = const(2)

src/trezor/messages/wire_types.py

@@ -1,3 +1,6 @@
+# Automatically generated by pb2py
+from micropython import const
+
 WordRequest = const(46)
 DebugLinkMemoryWrite = const(112)
 ButtonAck = const(27)

src/trezor/ui/__init__.py

@@ -1,3 +1,5 @@
+from micropython import const
+
 import sys
 import math
 import utime

src/trezor/ui/pin.py

@@ -2,7 +2,7 @@ from micropython import const
 from trezor import ui, res
 from trezor.crypto import random
 from trezor.ui import display
-from treozr.ui.button import Button, BTN_CLICKED, CLEAR_BUTTON, CLEAR_BUTTON_ACTIVE
+from trezor.ui.button import Button, BTN_CLICKED, CLEAR_BUTTON, CLEAR_BUTTON_ACTIVE
 
 
 def digit_area(i):