arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-04-23 10:39:03 +00:00
Code Issues Releases Wiki Activity

chore(eckart): Differentiate input vectors for Eckhart due to different screen size

Browse Source
This commit is contained in:
Lukas Bielesch 2025-04-04 18:32:49 +02:00
parent 0aff97acd5
commit 8104979fe7
1 changed files with 37 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
tests/device_tests/bitcoin/test_signmessage.py
View File

@ -388,10 +388,25 @@ MESSAGE_LENGTHS = (
pytest.param("1\n2\n3\n4\n5\n6\n7", False, id="single_line_over"),
)
MESSAGE_LENGTHS_ECKHART = (
pytest.param("This is a very long message. " * 28, False, id="normal_text"),
pytest.param("ThisIsAMessageWithoutSpaces" * 29, False, id="no_spaces"),
pytest.param("ThisIsAMessageWithLongWords " * 28, False, id="long_words"),
pytest.param(
"This\nmessage\nhas\nnewlines\nafter\nevery\nsingle\none\nword",
False,
id="newlines",
),
pytest.param(
"Příšerně žluťoučký kůň úpěl ďábelské ódy. " * 20, True, id="utf_text"
),
pytest.param("PříšerněŽluťoučkýKůňÚpělĎábelskéÓdy" * 23, True, id="utf_nospace"),
pytest.param("1\n2\n3\n4\n5\n6\n7\n8\n9", False, id="single_line_over"),
)
def _pagination_test(client: Client, message: str, is_long: bool):
@pytest.mark.models("core")
@pytest.mark.parametrize("message,is_long", MESSAGE_LENGTHS)
def test_signmessage_pagination(client: Client, message: str, is_long: bool):
with client:
IF = (
InputFlowSignVerifyMessageLong
@ -406,14 +421,29 @@ def test_signmessage_pagination(client: Client, message: str, is_long: bool):
message=message,
)
# We cannot differentiate between a newline and space in the message read from Trezor.
# TODO: do the check also for T2B1
message_read = IF.message_read.replace(" ", "").replace("...", "")
signed_message = message.replace("\n", "").replace(" ", "")
if client.layout_type in (LayoutType.Bolt, LayoutType.Delizia, LayoutType.Eckhart):
message_read = IF.message_read.replace(" ", "").replace("...", "")
signed_message = message.replace("\n", "").replace(" ", "")
assert signed_message in message_read
@pytest.mark.models(
"core",
skip=["eckhart"],
reason="Test with different parameters implemented for eckhart",
)
@pytest.mark.parametrize("message,is_long", MESSAGE_LENGTHS)
def test_signmessage_pagination(client: Client, message: str, is_long: bool):
_pagination_test(client, message, is_long)
@pytest.mark.models("eckhart")
@pytest.mark.parametrize("message,is_long", MESSAGE_LENGTHS_ECKHART)
def test_signmessage_pagination_eckhart(client: Client, message: str, is_long: bool):
_pagination_test(client, message, is_long)
@pytest.mark.models("t2t1", reason="Tailored to TT fonts and screen size")
def test_signmessage_pagination_trailing_newline(client: Client):
message = "THIS\nMUST\nNOT\nBE\nPAGINATED\n"