arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-07-08 07:38:11 +00:00
Code Issues Releases Wiki Activity

feat(tests): reuse same client instance across test session

Browse Source 
Makes skipping tests much faster, and running individual tests a tiny
bit faster.

Also makes sure the whole suite always runs against the same device
(modulo emulator being restarted)
This commit is contained in:
matejcik 2021-07-30 13:59:16 +02:00 committed by matejcik
parent 92e9d61e24
commit 7e0e24430c
1 changed files with 28 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
tests/conftest.py
View File

@ -28,7 +28,8 @@ from .device_handler import BackgroundDeviceHandler
from .ui_tests.reporting import testreport from .ui_tests.reporting import testreport
def get_device(): @pytest.fixture(scope="session")
def _raw_client(request):
path = os.environ.get("TREZOR_PATH") path = os.environ.get("TREZOR_PATH")
interact = int(os.environ.get("INTERACT", 0)) interact = int(os.environ.get("INTERACT", 0))
if path: if path:
@ -36,6 +37,7 @@ def get_device():
transport = get_transport(path) transport = get_transport(path)
return TrezorClientDebugLink(transport, auto_interact=not interact) return TrezorClientDebugLink(transport, auto_interact=not interact)
except Exception as e: except Exception as e:
request.session.shouldstop = "Failed to communicate with Trezor"
raise RuntimeError("Failed to open debuglink for {}".format(path)) from e raise RuntimeError("Failed to open debuglink for {}".format(path)) from e
else: else:
@ -46,11 +48,12 @@ def get_device():
except Exception: except Exception:
pass pass
else: else:
request.session.shouldstop = "Failed to communicate with Trezor"
raise RuntimeError("No debuggable device found") raise RuntimeError("No debuggable device found")
@pytest.fixture(scope="function") @pytest.fixture(scope="function")
def client(request): def client(request, _raw_client):
"""Client fixture. """Client fixture.
Every test function that requires a client instance will get it from here. Every test function that requires a client instance will get it from here.
@ -70,19 +73,13 @@ def client(request):
@pytest.mark.setup_client(uninitialized=True) @pytest.mark.setup_client(uninitialized=True)
""" """
try: if request.node.get_closest_marker("skip_t2") and _raw_client.features.model == "T":
client = get_device()
except RuntimeError:
request.session.shouldstop = "No debuggable Trezor is available"
pytest.fail("No debuggable Trezor is available")
if request.node.get_closest_marker("skip_t2") and client.features.model == "T":
pytest.skip("Test excluded on Trezor T") pytest.skip("Test excluded on Trezor T")
if request.node.get_closest_marker("skip_t1") and client.features.model == "1": if request.node.get_closest_marker("skip_t1") and _raw_client.features.model == "1":
pytest.skip("Test excluded on Trezor 1") pytest.skip("Test excluded on Trezor 1")
sd_marker = request.node.get_closest_marker("sd_card") sd_marker = request.node.get_closest_marker("sd_card")
if sd_marker and not client.features.sd_card_present: if sd_marker and not _raw_client.features.sd_card_present:
raise RuntimeError( raise RuntimeError(
"This test requires SD card.\n" "This test requires SD card.\n"
"To skip all such tests, run:\n" "To skip all such tests, run:\n"
@ -92,16 +89,23 @@ def client(request):
test_ui = request.config.getoption("ui") test_ui = request.config.getoption("ui")
run_ui_tests = not request.node.get_closest_marker("skip_ui") and test_ui run_ui_tests = not request.node.get_closest_marker("skip_ui") and test_ui
client.open() _raw_client.reset_debug_features()
_raw_client.open()
try:
_raw_client.init_device()
except Exception:
request.session.shouldstop = "Failed to communicate with Trezor"
pytest.fail("Failed to communicate with Trezor")
if run_ui_tests: if run_ui_tests:
# we need to reseed before the wipe # we need to reseed before the wipe
client.debug.reseed(0) _raw_client.debug.reseed(0)
if sd_marker: if sd_marker:
should_format = sd_marker.kwargs.get("formatted", True) should_format = sd_marker.kwargs.get("formatted", True)
client.debug.erase_sd_card(format=should_format) _raw_client.debug.erase_sd_card(format=should_format)
wipe_device(client) wipe_device(_raw_client)
setup_params = dict( setup_params = dict(
uninitialized=False, uninitialized=False,
@ -122,7 +126,7 @@ def client(request):
if not setup_params["uninitialized"]: if not setup_params["uninitialized"]:
debuglink.load_device( debuglink.load_device(
client, _raw_client,
mnemonic=setup_params["mnemonic"], mnemonic=setup_params["mnemonic"],
pin=setup_params["pin"], pin=setup_params["pin"],
passphrase_protection=use_passphrase, passphrase_protection=use_passphrase,
@ -132,21 +136,21 @@ def client(request):
no_backup=setup_params["no_backup"], no_backup=setup_params["no_backup"],
) )
if client.features.model == "T": if _raw_client.features.model == "T":
apply_settings(client, experimental_features=True) apply_settings(_raw_client, experimental_features=True)
if use_passphrase and isinstance(setup_params["passphrase"], str): if use_passphrase and isinstance(setup_params["passphrase"], str):
client.use_passphrase(setup_params["passphrase"]) _raw_client.use_passphrase(setup_params["passphrase"])
client.clear_session() _raw_client.clear_session()
if run_ui_tests: if run_ui_tests:
with ui_tests.screen_recording(client, request): with ui_tests.screen_recording(_raw_client, request):
yield client yield _raw_client
else: else:
yield client yield _raw_client
client.close() _raw_client.close()
def pytest_sessionstart(session): def pytest_sessionstart(session):