arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-23 23:08:14 +00:00
Code Issues Releases Wiki Activity

common/tools: Check for collisions between U2F app IDs and WebAuthn RP ID hashes.

Browse Source
This commit is contained in:
Andrew Kozlik 2020-07-30 12:16:49 +02:00 committed by Andrew Kozlik
parent 7d07161efe
commit 7c66a16bef
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
common/tools/cointool.py
View File

@ -507,6 +507,27 @@ def check_fido(apps):
print_log(logging.ERROR, webauthn_str, bucket_str)
check_passed = False
domain_hashes = {}
for app in apps:
if "webauthn" in app:
for domain in app["webauthn"]:
domain_hashes[sha256(domain.encode()).digest()] = domain
for app in apps:
if "u2f" in app:
for u2f in app["u2f"]:
domain = domain_hashes.get(bytes.fromhex(u2f["app_id"]))
if domain:
print_log(
logging.ERROR,
"colliding WebAuthn domain "
+ crayon(None, domain, bold=True)
+ " and U2F app_id "
+ crayon(None, u2f["app_id"], bold=True)
+ " for "
+ u2f["label"],
)
check_passed = False
for app in apps:
if "name" not in app:
print_log(logging.ERROR, app["key"], ": missing name")