arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-05-08 09:58:46 +00:00
Code Issues Releases Wiki Activity

More input sanity checks in EthereumSignTx

Browse Source
This commit is contained in:
Alex Beregszaszi 2016-05-25 15:39:11 +01:00
parent a617200c9c
commit 78b1370de9
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
firmware/ethereum.c
View File

@ -202,10 +202,17 @@ void ethereum_signing_init(EthereumSignTx *msg, const HDNode *node)
/* FIXME: simplify this check */ /* FIXME: simplify this check */
if (msg->has_data_initial_chunk) { if (msg->has_data_initial_chunk) {
if (msg->has_data_length && msg->data_initial_chunk.size != 1024) { if (msg->has_data_length) {
fsm_sendFailure(FailureType_Failure_Other, "Data length provided, but initial chunk too small"); if (msg->data_initial_chunk.size != 1024) {
ethereum_signing_abort(); fsm_sendFailure(FailureType_Failure_Other, "Data length provided, but initial chunk too small");
return; ethereum_signing_abort();
return;
}
if (msg->data_length == 0) {
fsm_sendFailure(FailureType_Failure_Other, "Invalid data length provided");
ethereum_signing_abort();
return;
}
} }
} else if (msg->has_data_length) { } else if (msg->has_data_length) {
fsm_sendFailure(FailureType_Failure_Other, "Data length provided, but no initial chunk"); fsm_sendFailure(FailureType_Failure_Other, "Data length provided, but no initial chunk");