arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-11-18 05:28:40 +00:00
Code Issues Releases Wiki Activity

refactor(legacy): Move script type functions to crypto.h.

Browse Source
This commit is contained in:
Andrew Kozlik 2022-12-15 10:58:25 +01:00 committed by matejcik
parent 11109b4e46
commit 779f5dbc7d
3 changed files with 102 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

83
legacy/firmware/crypto.c
View File

@ -735,3 +735,86 @@ bool coin_path_check(const CoinInfo *coin, InputScriptType script_type,
// unknown path // unknown path
return false; return false;
} }
bool is_multisig_input_script_type(InputScriptType script_type) {
// we do not support Multisig with Taproot yet
if (script_type == InputScriptType_SPENDMULTISIG ||
script_type == InputScriptType_SPENDP2SHWITNESS ||
script_type == InputScriptType_SPENDWITNESS) {
return true;
}
return false;
}
bool is_multisig_output_script_type(OutputScriptType script_type) {
// we do not support Multisig with Taproot yet
if (script_type == OutputScriptType_PAYTOMULTISIG ||
script_type == OutputScriptType_PAYTOP2SHWITNESS ||
script_type == OutputScriptType_PAYTOWITNESS) {
return true;
}
return false;
}
bool is_internal_input_script_type(InputScriptType script_type) {
if (script_type == InputScriptType_SPENDADDRESS ||
script_type == InputScriptType_SPENDMULTISIG ||
script_type == InputScriptType_SPENDP2SHWITNESS ||
script_type == InputScriptType_SPENDWITNESS ||
script_type == InputScriptType_SPENDTAPROOT) {
return true;
}
return false;
}
bool is_change_output_script_type(OutputScriptType script_type) {
if (script_type == OutputScriptType_PAYTOADDRESS ||
script_type == OutputScriptType_PAYTOMULTISIG ||
script_type == OutputScriptType_PAYTOP2SHWITNESS ||
script_type == OutputScriptType_PAYTOWITNESS ||
script_type == OutputScriptType_PAYTOTAPROOT) {
return true;
}
return false;
}
bool is_segwit_input_script_type(InputScriptType script_type) {
if (script_type == InputScriptType_SPENDP2SHWITNESS ||
script_type == InputScriptType_SPENDWITNESS ||
script_type == InputScriptType_SPENDTAPROOT) {
return true;
}
return false;
}
bool is_segwit_output_script_type(OutputScriptType script_type) {
if (script_type == OutputScriptType_PAYTOP2SHWITNESS ||
script_type == OutputScriptType_PAYTOWITNESS ||
script_type == OutputScriptType_PAYTOTAPROOT) {
return true;
}
return false;
}
bool change_output_to_input_script_type(OutputScriptType output_script_type,
InputScriptType *input_script_type) {
switch (output_script_type) {
case OutputScriptType_PAYTOADDRESS:
*input_script_type = InputScriptType_SPENDADDRESS;
return true;
case OutputScriptType_PAYTOMULTISIG:
*input_script_type = InputScriptType_SPENDMULTISIG;
return true;
case OutputScriptType_PAYTOWITNESS:
*input_script_type = InputScriptType_SPENDWITNESS;
return true;
case OutputScriptType_PAYTOP2SHWITNESS:
*input_script_type = InputScriptType_SPENDP2SHWITNESS;
return true;
case OutputScriptType_PAYTOTAPROOT:
*input_script_type = InputScriptType_SPENDTAPROOT;
return true;
default:
return false;
}
}

9
legacy/firmware/crypto.h
View File

@ -82,4 +82,13 @@ bool coin_path_check(const CoinInfo *coin, InputScriptType script_type,
uint32_t address_n_count, const uint32_t *address_n, uint32_t address_n_count, const uint32_t *address_n,
bool has_multisig, bool full_check); bool has_multisig, bool full_check);
bool is_multisig_input_script_type(InputScriptType script_type);
bool is_multisig_output_script_type(OutputScriptType script_type);
bool is_internal_input_script_type(InputScriptType script_type);
bool is_change_output_script_type(OutputScriptType script_type);
bool is_segwit_input_script_type(InputScriptType script_type);
bool is_segwit_output_script_type(OutputScriptType script_type);
bool change_output_to_input_script_type(OutputScriptType output_script_type,
InputScriptType *input_script_type);
#endif #endif

78
legacy/firmware/signing.c
View File

@ -1165,66 +1165,6 @@ void signing_init(const SignTx *msg, const CoinInfo *_coin,
#define MIN(a, b) (((a) < (b)) ? (a) : (b)) #define MIN(a, b) (((a) < (b)) ? (a) : (b))
static bool is_multisig_input_script_type(const TxInputType *txinput) {
// we do not support Multisig with Taproot yet
if (txinput->script_type == InputScriptType_SPENDMULTISIG ||
txinput->script_type == InputScriptType_SPENDP2SHWITNESS ||
txinput->script_type == InputScriptType_SPENDWITNESS) {
return true;
}
return false;
}
static bool is_multisig_output_script_type(const TxOutputType *txoutput) {
// we do not support Multisig with Taproot yet
if (txoutput->script_type == OutputScriptType_PAYTOMULTISIG ||
txoutput->script_type == OutputScriptType_PAYTOP2SHWITNESS ||
txoutput->script_type == OutputScriptType_PAYTOWITNESS) {
return true;
}
return false;
}
static bool is_internal_input_script_type(const TxInputType *txinput) {
if (txinput->script_type == InputScriptType_SPENDADDRESS ||
txinput->script_type == InputScriptType_SPENDMULTISIG ||
txinput->script_type == InputScriptType_SPENDP2SHWITNESS ||
txinput->script_type == InputScriptType_SPENDWITNESS ||
txinput->script_type == InputScriptType_SPENDTAPROOT) {
return true;
}
return false;
}
static bool is_change_output_script_type(const TxOutputType *txoutput) {
if (txoutput->script_type == OutputScriptType_PAYTOADDRESS ||
txoutput->script_type == OutputScriptType_PAYTOMULTISIG ||
txoutput->script_type == OutputScriptType_PAYTOP2SHWITNESS ||
txoutput->script_type == OutputScriptType_PAYTOWITNESS ||
txoutput->script_type == OutputScriptType_PAYTOTAPROOT) {
return true;
}
return false;
}
static bool is_segwit_input_script_type(const TxInputType *txinput) {
if (txinput->script_type == InputScriptType_SPENDP2SHWITNESS ||
txinput->script_type == InputScriptType_SPENDWITNESS ||
txinput->script_type == InputScriptType_SPENDTAPROOT) {
return true;
}
return false;
}
static bool is_segwit_output_script_type(const TxOutputType *txoutput) {
if (txoutput->script_type == OutputScriptType_PAYTOP2SHWITNESS ||
txoutput->script_type == OutputScriptType_PAYTOWITNESS ||
txoutput->script_type == OutputScriptType_PAYTOTAPROOT) {
return true;
}
return false;
}
static bool signing_validate_input(const TxInputType *txinput) { static bool signing_validate_input(const TxInputType *txinput) {
if (txinput->prev_hash.size != 32) { if (txinput->prev_hash.size != 32) {
fsm_sendFailure(FailureType_Failure_ProcessError, fsm_sendFailure(FailureType_Failure_ProcessError,
@ -1233,14 +1173,15 @@ static bool signing_validate_input(const TxInputType *txinput) {
return false; return false;
} }
if (txinput->has_multisig && !is_multisig_input_script_type(txinput)) { if (txinput->has_multisig &&
!is_multisig_input_script_type(txinput->script_type)) {
fsm_sendFailure(FailureType_Failure_DataError, fsm_sendFailure(FailureType_Failure_DataError,
_("Multisig field provided but not expected.")); _("Multisig field provided but not expected."));
signing_abort(); signing_abort();
return false; return false;
} }
if (is_internal_input_script_type(txinput)) { if (is_internal_input_script_type(txinput->script_type)) {
if (txinput->has_script_pubkey) { if (txinput->has_script_pubkey) {
// scriptPubKey should only be provided for external inputs // scriptPubKey should only be provided for external inputs
fsm_sendFailure(FailureType_Failure_DataError, fsm_sendFailure(FailureType_Failure_DataError,
@ -1270,7 +1211,7 @@ static bool signing_validate_input(const TxInputType *txinput) {
return false; return false;
} }
if (is_segwit_input_script_type(txinput)) { if (is_segwit_input_script_type(txinput->script_type)) {
if (!coin->has_segwit) { if (!coin->has_segwit) {
fsm_sendFailure(FailureType_Failure_DataError, fsm_sendFailure(FailureType_Failure_DataError,
_("Segwit not enabled on this coin")); _("Segwit not enabled on this coin"));
@ -1307,7 +1248,8 @@ static bool signing_validate_input(const TxInputType *txinput) {
} }
static bool signing_validate_output(TxOutputType *txoutput) { static bool signing_validate_output(TxOutputType *txoutput) {
if (txoutput->has_multisig && !is_multisig_output_script_type(txoutput)) { if (txoutput->has_multisig &&
!is_multisig_output_script_type(txoutput->script_type)) {
fsm_sendFailure(FailureType_Failure_DataError, fsm_sendFailure(FailureType_Failure_DataError,
_("Multisig field provided but not expected.")); _("Multisig field provided but not expected."));
signing_abort(); signing_abort();
@ -1315,7 +1257,7 @@ static bool signing_validate_output(TxOutputType *txoutput) {
} }
if (txoutput->address_n_count > 0 && if (txoutput->address_n_count > 0 &&
!is_change_output_script_type(txoutput)) { !is_change_output_script_type(txoutput->script_type)) {
fsm_sendFailure(FailureType_Failure_DataError, fsm_sendFailure(FailureType_Failure_DataError,
_("Output's address_n provided but not expected.")); _("Output's address_n provided but not expected."));
signing_abort(); signing_abort();
@ -1356,7 +1298,7 @@ static bool signing_validate_output(TxOutputType *txoutput) {
} }
} }
if (is_segwit_output_script_type(txoutput)) { if (is_segwit_output_script_type(txoutput->script_type)) {
if (!coin->has_segwit) { if (!coin->has_segwit) {
fsm_sendFailure(FailureType_Failure_DataError, fsm_sendFailure(FailureType_Failure_DataError,
_("Segwit not enabled on this coin")); _("Segwit not enabled on this coin"));
@ -1653,7 +1595,7 @@ static bool signing_check_prevtx_hash(void) {
static bool is_change_output(const TxInfo *tx_info, static bool is_change_output(const TxInfo *tx_info,
const TxOutputType *txoutput) { const TxOutputType *txoutput) {
if (!is_change_output_script_type(txoutput)) { if (!is_change_output_script_type(txoutput->script_type)) {
return false; return false;
} }
@ -2907,7 +2849,7 @@ void signing_txack(TransactionType *tx) {
info.next_legacy_input = idx1; info.next_legacy_input = idx1;
} }
} }
} else if (is_segwit_input_script_type(&tx->inputs[0])) { } else if (is_segwit_input_script_type(tx->inputs[0].script_type)) {
if (!to.is_segwit) { if (!to.is_segwit) {
tx_weight += TXSIZE_SEGWIT_OVERHEAD + to.inputs_len; tx_weight += TXSIZE_SEGWIT_OVERHEAD + to.inputs_len;
} }