arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-06-30 20:02:34 +00:00
Code Issues Releases Wiki Activity

legacy: correctly handle set/clear flags

Browse Source
This commit is contained in:
Pavol Rusnak 2019-09-24 14:31:51 +00:00
parent 31494dad6c
commit 6a9d986e20
No known key found for this signature in database
GPG Key ID: 91F3B339B9A02A3D
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
legacy/firmware/stellar.c
View File

@ -607,6 +607,10 @@ bool stellar_confirmSetOptionsOp(const StellarSetOptionsOp *msg) {
strlcpy(str_title, _("Clear Flag(s)"), sizeof(str_title)); strlcpy(str_title, _("Clear Flag(s)"), sizeof(str_title));
// Auth required // Auth required
if (msg->clear_flags > 7) {
stellar_signingAbort(_("Invalid flags"));
return false;
}
if (msg->clear_flags & 0x01) { if (msg->clear_flags & 0x01) {
strlcpy(rows[row_idx], _("AUTH_REQUIRED"), sizeof(rows[row_idx])); strlcpy(rows[row_idx], _("AUTH_REQUIRED"), sizeof(rows[row_idx]));
row_idx++; row_idx++;
@ -616,6 +620,11 @@ bool stellar_confirmSetOptionsOp(const StellarSetOptionsOp *msg) {
strlcpy(rows[row_idx], _("AUTH_REVOCABLE"), sizeof(rows[row_idx])); strlcpy(rows[row_idx], _("AUTH_REVOCABLE"), sizeof(rows[row_idx]));
row_idx++; row_idx++;
} }
// Auth immutable
if (msg->clear_flags & 0x04) {
strlcpy(rows[row_idx], _("AUTH_IMMUTABLE"), sizeof(rows[row_idx]));
row_idx++;
}
stellar_layoutTransactionDialog(str_title, rows[0], rows[1], rows[2], stellar_layoutTransactionDialog(str_title, rows[0], rows[1], rows[2],
rows[3]); rows[3]);
@ -636,6 +645,10 @@ bool stellar_confirmSetOptionsOp(const StellarSetOptionsOp *msg) {
strlcpy(str_title, _("Set Flag(s)"), sizeof(str_title)); strlcpy(str_title, _("Set Flag(s)"), sizeof(str_title));
// Auth required // Auth required
if (msg->set_flags > 7) {
stellar_signingAbort(_("Invalid flags"));
return false;
}
if (msg->set_flags & 0x01) { if (msg->set_flags & 0x01) {
strlcpy(rows[row_idx], _("AUTH_REQUIRED"), sizeof(rows[row_idx])); strlcpy(rows[row_idx], _("AUTH_REQUIRED"), sizeof(rows[row_idx]));
row_idx++; row_idx++;
@ -645,6 +658,11 @@ bool stellar_confirmSetOptionsOp(const StellarSetOptionsOp *msg) {
strlcpy(rows[row_idx], _("AUTH_REVOCABLE"), sizeof(rows[row_idx])); strlcpy(rows[row_idx], _("AUTH_REVOCABLE"), sizeof(rows[row_idx]));
row_idx++; row_idx++;
} }
// Auth immutable
if (msg->set_flags & 0x04) {
strlcpy(rows[row_idx], _("AUTH_IMMUTABLE"), sizeof(rows[row_idx]));
row_idx++;
}
stellar_layoutTransactionDialog(str_title, rows[0], rows[1], rows[2], stellar_layoutTransactionDialog(str_title, rows[0], rows[1], rows[2],
rows[3]); rows[3]);