arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-08-01 19:38:33 +00:00
Code Issues Releases Wiki Activity

Revert "feat(python): add warning for insecure CoSi firmware"

Browse Source 
This reverts commit 1afc78e368.
This commit is contained in:
tychovrahe 2022-11-08 14:57:47 +01:00
parent 1861acaca1
commit 6a4f047d91
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
python/src/trezorlib/cli/cosi.py
View File

@ -14,6 +14,7 @@
# You should have received a copy of the License along with this library. # You should have received a copy of the License along with this library.
# If not, see <https://www.gnu.org/licenses/lgpl-3.0.html>. # If not, see <https://www.gnu.org/licenses/lgpl-3.0.html>.
import warnings
from typing import TYPE_CHECKING, Optional from typing import TYPE_CHECKING, Optional
import click import click
@ -33,14 +34,6 @@ def cli() -> None:
"""CoSi (Cothority / collective signing) commands.""" """CoSi (Cothority / collective signing) commands."""
def cosi_warn(client: "TrezorClient") -> None:
if client.features.model == "1" and client.version < (1, 11, 2):
click.echo("WARNING: CoSi signing on your Trezor is insecure.")
click.echo("Please update your Trezor to firmware version 1.11.2 or newer.")
click.echo("If you used CoSi in the past, consider rotating your keys.")
raise click.Abort()
@cli.command() @cli.command()
@click.option("-n", "--address", required=True, help=PATH_HELP) @click.option("-n", "--address", required=True, help=PATH_HELP)
@click.argument("data_deprecated", required=False) @click.argument("data_deprecated", required=False)
@ -49,9 +42,8 @@ def commit(
client: "TrezorClient", address: str, data_deprecated: Optional[str] client: "TrezorClient", address: str, data_deprecated: Optional[str]
) -> "messages.CosiCommitment": ) -> "messages.CosiCommitment":
"""Ask device to commit to CoSi signing.""" """Ask device to commit to CoSi signing."""
cosi_warn(client)
if data_deprecated is not None: if data_deprecated is not None:
click.echo("Warning: data argument is deprecated", err=True) warnings.warn("'data' argument is deprecated")
address_n = tools.parse_path(address) address_n = tools.parse_path(address)
return cosi.commit(client, address_n) return cosi.commit(client, address_n)
@ -71,7 +63,6 @@ def sign(
global_pubkey: str, global_pubkey: str,
) -> "messages.CosiSignature": ) -> "messages.CosiSignature":
"""Ask device to sign using CoSi.""" """Ask device to sign using CoSi."""
cosi_warn(client)
address_n = tools.parse_path(address) address_n = tools.parse_path(address)
return cosi.sign( return cosi.sign(
client, client,