arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-02-18 18:42:06 +00:00
Code Issues Releases Wiki Activity

Merge pull request #49 from romanz/master

Browse Source 
bignum: constant time implementation for bn_mod()
This commit is contained in:
Pavol Rusnak 2015-08-31 20:27:29 +02:00
commit 57cee67855
2 changed files with 11 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
bignum.c
View File

@ -229,27 +229,10 @@ void bn_mult_k(bignum256 *x, uint8_t k, const bignum256 *prime)
// assumes x partly reduced, guarantees x fully reduced. // assumes x partly reduced, guarantees x fully reduced.
void bn_mod(bignum256 *x, const bignum256 *prime) void bn_mod(bignum256 *x, const bignum256 *prime)
{ {
int i = 8; const int flag = bn_is_less(x, prime); // x < prime
uint32_t temp; bignum256 temp;
// compare numbers bn_subtract(x, prime, &temp); // temp = x - prime
while (i >= 0 && prime->val[i] == x->val[i]) i--; bn_cmov(x, flag, x, &temp);
// if equal
if (i == -1) {
// set x to zero
bn_zero(x);
} else {
// if x is greater
if (x->val[i] > prime->val[i]) {
// substract p from x
temp = 0x40000000u;
for (i = 0; i < 9; i++) {
temp += x->val[i] - prime->val[i];
x->val[i] = temp & 0x3FFFFFFF;
temp >>= 30;
temp += 0x3FFFFFFFu;
}
}
}
} }
// auxiliary function for multiplication. // auxiliary function for multiplication.

7
test_curves.py
View File

@ -261,6 +261,13 @@ def test_mod(curve, r):
lib.bn_mod(y, int2bn(curve.p)) lib.bn_mod(y, int2bn(curve.p))
assert bn2int(y) == x % curve.p assert bn2int(y) == x % curve.p
def test_mod_specific(curve):
p = curve.p
for x in [0, 1, 2, p - 2, p - 1, p, p + 1, p + 2, 2*p - 2, 2*p - 1]:
y = int2bn(x)
lib.bn_mod(y, int2bn(curve.p))
assert bn2int(y) == x % p
POINT = BIGNUM * 2 POINT = BIGNUM * 2
to_POINT = lambda p: POINT(int2bn(p.x()), int2bn(p.y())) to_POINT = lambda p: POINT(int2bn(p.x()), int2bn(p.y()))
from_POINT = lambda p: (bn2int(p[0]), bn2int(p[1])) from_POINT = lambda p: (bn2int(p[0]), bn2int(p[1]))