arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-04-30 05:59:02 +00:00
Code Issues Releases Wiki Activity

fix(python): bring back firmware version check

Browse Source
This commit is contained in:
Martin Milata 2025-02-27 17:07:28 +01:00 committed by M1nd3r
parent 8d42279f83
commit 51ac73bedb
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
python/src/trezorlib/cli/trezorctl.py
View File

@ -325,8 +325,6 @@ def version() -> str:
@with_session(empty_passphrase=True) @with_session(empty_passphrase=True)
def ping(session: "Session", message: str, button_protection: bool) -> str: def ping(session: "Session", message: str, button_protection: bool) -> str:
"""Send ping message.""" """Send ping message."""
# TODO return short-circuit from old client for old Trezors
return session.ping(message, button_protection) return session.ping(message, button_protection)

15
python/src/trezorlib/client.py
View File

@ -18,6 +18,7 @@ from __future__ import annotations
import logging import logging
import os import os
import typing as t import typing as t
import warnings
from enum import IntEnum from enum import IntEnum
from . import exceptions, mapping, messages, models from . import exceptions, mapping, messages, models
@ -135,6 +136,7 @@ class TrezorClient:
def features(self) -> messages.Features: def features(self) -> messages.Features:
if self._features is None: if self._features is None:
self._features = self.protocol.get_features() self._features = self.protocol.get_features()
self.check_firmware_version(warn_only=True)
assert self._features is not None assert self._features is not None
return self._features return self._features
@ -168,12 +170,25 @@ class TrezorClient:
def refresh_features(self) -> messages.Features: def refresh_features(self) -> messages.Features:
self.protocol.update_features() self.protocol.update_features()
self._features = self.protocol.get_features() self._features = self.protocol.get_features()
self.check_firmware_version(warn_only=True)
return self._features return self._features
def _get_protocol(self) -> Channel: def _get_protocol(self) -> Channel:
protocol = ProtocolV1Channel(self.transport, mapping.DEFAULT_MAPPING) protocol = ProtocolV1Channel(self.transport, mapping.DEFAULT_MAPPING)
return protocol return protocol
def is_outdated(self) -> bool:
if self.features.bootloader_mode:
return False
return self.version < self.model.minimum_version
def check_firmware_version(self, warn_only: bool = False) -> None:
if self.is_outdated():
if warn_only:
warnings.warn("Firmware is out of date", stacklevel=2)
else:
raise exceptions.OutdatedFirmwareError(OUTDATED_FIRMWARE_ERROR)
def get_default_client( def get_default_client(
path: t.Optional[str] = None, path: t.Optional[str] = None,