arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-07-06 14:52:33 +00:00
Code Issues Releases Wiki Activity

perf(core): allow GC to free confirmation-related objects

Browse Source 
[no changelog]
This commit is contained in:
Roman Zeyde 2025-03-19 17:34:06 +02:00
parent 9b29cd2027
commit 4e4d62e5a0
1 changed files with 34 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
core/src/apps/management/change_language.py
View File

@ -63,40 +63,46 @@ async def do_change_language(
import storage.device import storage.device
from trezor import utils from trezor import utils
if data_length > translations.area_bytesize(): async def _confirm_request() -> tuple[bytes, bool]:
raise DataError("Translations too long") if data_length > translations.area_bytesize():
raise DataError("Translations too long")
# Getting and parsing the header # Getting and parsing the header
header_data = await _get_data_chunk(data_length, 0) header_data = await _get_data_chunk(data_length, 0)
try: try:
header = translations.TranslationsHeader(header_data) header = translations.TranslationsHeader(header_data)
except (ValueError, EOFError): except (ValueError, EOFError):
raise DataError("Invalid translations data") raise DataError("Invalid translations data")
# Verifying header information # Verifying header information
if header.total_len != data_length: if header.total_len != data_length:
raise DataError("Invalid data length") raise DataError("Invalid data length")
if header.version != expected_version: if header.version != expected_version:
raise DataError("Translations version mismatch") raise DataError("Translations version mismatch")
current_header = translations.TranslationsHeader.load_from_flash() current_header = translations.TranslationsHeader.load_from_flash()
if current_header is None: if current_header is None:
# if no blob is present, but the device is set up, we consider the language # if no blob is present, but the device is set up, we consider the language
# being ""explicitly set"" to English # being ""explicitly set"" to English
silent_install = not storage.device.is_initialized() silent_install = not storage.device.is_initialized()
else: else:
# if a blob is present, it can only be silently upgraded to expected_version # if a blob is present, it can only be silently upgraded to expected_version
silent_install = ( silent_install = (
current_header.language == header.language current_header.language == header.language
and current_header.version != expected_version and current_header.version != expected_version
) )
# Confirm with user # Confirm with user
await _require_confirm_change_language(header, silent_install, show_display) await _require_confirm_change_language(header, silent_install, show_display)
# Initiate loader # Initiate loader
report(0) report(0)
return header_data, silent_install
# Allow GC to free all the above objects before allocating the blob below
header_data, silent_install = await _confirm_request()
# Loading all the data at once, so we can verify its fingerprint # Loading all the data at once, so we can verify its fingerprint
# If we saved it gradually to the storage and only checked the fingerprint at the end # If we saved it gradually to the storage and only checked the fingerprint at the end