arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-07-15 02:58:12 +00:00
Code Issues Releases Wiki Activity

tools/support.py: set --ignore-tokens as default when running the checks

Browse Source
This commit is contained in:
matejcik 2018-11-12 12:07:50 +01:00
parent 0fd94f6bee
commit 491f1c1ad2
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.travis.yml
View File

@ -24,7 +24,7 @@ script:
- jsonlint defs/*.json - jsonlint defs/*.json
- jsonlint defs/*/*.json - jsonlint defs/*/*.json
- python tools/cointool.py check - python tools/cointool.py check
- python tools/support.py check --ignore-tokens --ignore-missing - python tools/support.py check --ignore-missing
- python protob/graph.py protob/*.proto - python protob/graph.py protob/*.proto
notifications: notifications:

12
tools/support.py
View File

@ -227,18 +227,18 @@ def fix(dry_run):
@cli.command() @cli.command()
# fmt: off # fmt: off
@click.option("-t", "--ignore-tokens", is_flag=True, help="Ignore unsupported ERC20 tokens") @click.option("-T", "--check-tokens", is_flag=True, help="Also check unsupported ERC20 tokens, ignored by default")
@click.option("-m", "--ignore-missing", is_flag=True, help="Do not fail on missing supportinfo") @click.option("-m", "--ignore-missing", is_flag=True, help="Do not fail on missing supportinfo")
# fmt: on # fmt: on
def check(ignore_tokens, ignore_missing): def check(check_tokens, ignore_missing):
"""Check validity of support information. """Check validity of support information.
Ensures that `support.json` data is well formed, there are no keys without Ensures that `support.json` data is well formed, there are no keys without
corresponding coins, and there are no coins without corresponding keys. corresponding coins, and there are no coins without corresponding keys.
If `--ignore-tokens` is specified, the check will ignore ERC20 tokens If `--check-tokens` is specified, the check will also take into account ERC20 tokens
without support info. This is useful because there is usually a lot of ERC20 without support info. This is disabled by default, because support info for ERC20
tokens. tokens is not strictly required.
If `--ignore-missing` is specified, the check will display coins with missing If `--ignore-missing` is specified, the check will display coins with missing
support info, but will not fail when missing coins are found. This is support info, but will not fail when missing coins are found. This is
@ -261,7 +261,7 @@ def check(ignore_tokens, ignore_missing):
missing = find_unsupported_coins(coins_dict) missing = find_unsupported_coins(coins_dict)
for device, values in missing.items(): for device, values in missing.items():
if ignore_tokens: if not check_tokens:
values = [coin for coin in values if not coin_info.is_token(coin)] values = [coin for coin in values if not coin_info.is_token(coin)]
if values: if values:
if not ignore_missing: if not ignore_missing: