arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-07-27 08:58:28 +00:00
Code Issues Releases Wiki Activity

fix(core): halt on too-long-memo already during outputs confirmation phase

Browse Source
This commit is contained in:
Tomas Krnak 2022-12-27 17:04:01 +07:00
parent 2728438aa2
commit 40cfba5a70
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/apps/zcash/orchard/signer.py
View File

@ -102,6 +102,8 @@ class OrchardSigner:
async def approve_outputs(self) -> None: async def approve_outputs(self) -> None:
for i in range(self.params.outputs_count): for i in range(self.params.outputs_count):
txo = await self.get_output(i) txo = await self.get_output(i)
if txo.memo is not None and len(txo.memo.encode()) > 512:
raise DataError("Memo is too long.")
self.msg_acc.xor_message(txo, i) # add message to the accumulator self.msg_acc.xor_message(txo, i) # add message to the accumulator
if output_is_internal(txo): if output_is_internal(txo):
self.approver.add_orchard_change_output(txo) self.approver.add_orchard_change_output(txo)