arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-01-22 21:30:56 +00:00
Code Issues Releases Wiki Activity

fix(core): Fix stack-use-after-scope in display.c.

Browse Source 
[no changelog]
This commit is contained in:
Andrew Kozlik 2022-01-10 11:47:10 +01:00 committed by matejcik
parent b6ed573cf5
commit 39b64b8569
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/embed/extmod/modtrezorui/display.c
View File

@ -407,11 +407,11 @@ void display_loader(uint16_t progress, bool indeterminate, int yoffset,
DISPLAY_RESY / 2 - img_loader_size + yoffset, DISPLAY_RESY / 2 - img_loader_size + yoffset,
DISPLAY_RESX / 2 + img_loader_size - 1, DISPLAY_RESX / 2 + img_loader_size - 1,
DISPLAY_RESY / 2 + img_loader_size - 1 + yoffset); DISPLAY_RESY / 2 + img_loader_size - 1 + yoffset);
uint8_t icondata[(LOADER_ICON_SIZE * LOADER_ICON_SIZE) / 2] = {0};
if (icon && memcmp(icon, "TOIg", 4) == 0 && if (icon && memcmp(icon, "TOIg", 4) == 0 &&
LOADER_ICON_SIZE == *(uint16_t *)(icon + 4) && LOADER_ICON_SIZE == *(uint16_t *)(icon + 4) &&
LOADER_ICON_SIZE == *(uint16_t *)(icon + 6) && LOADER_ICON_SIZE == *(uint16_t *)(icon + 6) &&
iconlen == 12 + *(uint32_t *)(icon + 8)) { iconlen == 12 + *(uint32_t *)(icon + 8)) {
uint8_t icondata[(LOADER_ICON_SIZE * LOADER_ICON_SIZE) / 2] = {0};
memzero(&icondata, sizeof(icondata)); memzero(&icondata, sizeof(icondata));
struct uzlib_uncomp decomp = {0}; struct uzlib_uncomp decomp = {0};
uzlib_prepare(&decomp, NULL, icon + 12, iconlen - 12, icondata, uzlib_prepare(&decomp, NULL, icon + 12, iconlen - 12, icondata,