1
0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-22 14:28:07 +00:00

bootloader: refactor protobuf code

This commit is contained in:
Pavol Rusnak 2017-06-14 23:18:00 +02:00
parent 4414054d92
commit 396e90e19e
No known key found for this signature in database
GPG Key ID: 91F3B339B9A02A3D
3 changed files with 100 additions and 39 deletions

View File

@ -0,0 +1,4 @@
#define UPLOAD_CHUNK_SIZE (128*1024)
#define USB_PACKET_SIZE 64
#define USB_IFACE_NUM 0

View File

@ -13,6 +13,7 @@
#include "version.h"
#include "mini_printf.h"
#include "bootloader.h"
#include "messages.h"
#define IMAGE_MAGIC 0x465A5254 // TRZF
@ -89,9 +90,6 @@ void check_and_jump(void)
}
}
#define USB_PACKET_SIZE 64
#define USB_IFACE_NUM 0
int usb_init_all(void) {
static const usb_dev_info_t dev_info = {
.vendor_id = 0x1209,
@ -161,7 +159,6 @@ void mainloop(void)
uint8_t buf[USB_PACKET_SIZE];
for (;;) {
display_printf("Waiting for message ...\n");
int r = usb_hid_read_blocking(USB_IFACE_NUM, buf, USB_PACKET_SIZE, 100);
if (r <= 0) {
continue;

View File

@ -3,11 +3,10 @@
#include "usb.h"
#include "version.h"
#include "bootloader.h"
#include "messages.h"
#define UPLOAD_CHUNK_SIZE (128*1024)
// DECODE
bool msg_parse_header(const uint8_t *buf, uint16_t *msg_id, uint32_t *msg_size)
@ -22,7 +21,100 @@ bool msg_parse_header(const uint8_t *buf, uint16_t *msg_id, uint32_t *msg_size)
// ENCODE
bool _encode_string(pb_ostream_t *stream, const pb_field_t *field, void * const *arg)
typedef struct {
uint8_t iface_num;
uint8_t packet_index;
uint8_t packet_pos;
uint8_t buf[USB_PACKET_SIZE];
} usb_write_state;
static bool _usb_write(pb_ostream_t *stream, const pb_byte_t *buf, size_t count)
{
usb_write_state *state = (usb_write_state *)(stream->state);
size_t written = 0;
// while we have data left
while (written < count) {
size_t remaining = count - written;
// if all remaining data fit into our packet
if (state->packet_pos + remaining <= USB_PACKET_SIZE) {
// append data from buf to state->buf
memcpy(state->buf + state->packet_pos, buf + written, remaining);
// advance position
state->packet_pos += remaining;
// and return
return true;
} else {
// append data that fits
memcpy(state->buf + state->packet_pos, buf + written, USB_PACKET_SIZE - state->packet_pos);
written += USB_PACKET_SIZE - state->packet_pos;
// send packet
usb_hid_write_blocking(state->iface_num, state->buf, USB_PACKET_SIZE, 1);
// prepare new packet
state->packet_index++;
memset(state->buf, 0, USB_PACKET_SIZE);
state->buf[0] = '?';
state->packet_pos = 1;
}
}
return true;
}
static void _usb_flush(usb_write_state *state)
{
// if packet is not filled up completely
if (state->packet_pos < USB_PACKET_SIZE) {
// pad it with zeroes
memset(state->buf + state->packet_pos, 0, USB_PACKET_SIZE - state->packet_pos);
}
// send packet
usb_hid_write_blocking(state->iface_num, state->buf, USB_PACKET_SIZE, 1);
}
static bool _send_msg(uint8_t iface_num, uint16_t msg_id, const pb_field_t fields[], const void *msg)
{
// determine message size by serializing it into a dummy stream
pb_ostream_t sizestream = {
.callback = NULL,
.state = NULL,
.max_size = SIZE_MAX,
.bytes_written = 0,
.errmsg = NULL};
if (!pb_encode(&sizestream, fields, msg)) {
return false;
}
const uint32_t msg_size = sizestream.bytes_written;
usb_write_state state = {
.iface_num = iface_num,
.packet_index = 0,
.packet_pos = MSG_HEADER_LEN,
.buf = {
'?', '#', '#',
(msg_id >> 8) & 0xFF, msg_id & 0xFF,
(msg_size >> 24) & 0xFF, (msg_size >> 16) & 0xFF, (msg_size >> 8) & 0xFF, msg_size & 0xFF,
},
};
pb_ostream_t stream = {
.callback = &_usb_write,
.state = &state,
.max_size = SIZE_MAX,
.bytes_written = 0,
.errmsg = NULL
};
if (!pb_encode(&stream, fields, msg)) {
return false;
}
_usb_flush(&state);
return true;
}
static bool _encode_string(pb_ostream_t *stream, const pb_field_t *field, void * const *arg)
{
if (!pb_encode_tag_for_field(stream, field)) {
return false;
@ -30,38 +122,6 @@ bool _encode_string(pb_ostream_t *stream, const pb_field_t *field, void * const
return pb_encode_string(stream, *arg, strlen(*arg));
}
bool _send_msg(uint8_t iface_num, uint16_t msg_id, const pb_field_t fields[], const void *msg)
{
// determine message size by serializing it into dummy stream
pb_ostream_t sizestream = {0, 0, SIZE_MAX, 0, 0};
if (!pb_encode(&sizestream, fields, msg)) {
return false;
}
// TODO: properly send
uint8_t buf[64];
buf[0] = '?';
buf[1] = '#';
buf[2] = '#';
buf[3] = (msg_id >> 8) & 0xFF;
buf[4] = msg_id & 0xFF;
buf[5] = (sizestream.bytes_written >> 24) & 0xFF;
buf[6] = (sizestream.bytes_written >> 16) & 0xFF;
buf[7] = (sizestream.bytes_written >> 8) & 0xFF;
buf[8] = sizestream.bytes_written & 0xFF;
pb_ostream_t stream = pb_ostream_from_buffer(buf + MSG_HEADER_LEN, sizeof(buf) - MSG_HEADER_LEN);
if (!pb_encode(&stream, fields, msg)) {
return false;
}
usb_hid_write_blocking(iface_num, buf, 64, 1);
return true;
}
#define MSG_INIT(TYPE) TYPE msg = TYPE##_init_default
#define MSG_ASSIGN_VALUE(FIELD, VALUE) do { msg.has_##FIELD = true; msg.FIELD = VALUE; } while (0)
#define MSG_ASSIGN_STRING(FIELD, VALUE) do { msg.FIELD.funcs.encode = &_encode_string; msg.FIELD.arg = VALUE; } while (0)