arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-18 04:18:10 +00:00
Code Issues Releases Wiki Activity

feat(legacy): Strict path validation for Stellar.

Browse Source
This commit is contained in:
Andrew Kozlik 2022-01-26 18:47:20 +01:00 committed by Martin Milata
parent 0af5cd18c2
commit 35151c6157
3 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
legacy/firmware/fsm_msg_stellar.h
View File

@ -17,6 +17,20 @@
* along with this library. If not, see <http://www.gnu.org/licenses/>.
*/
static bool fsm_stellarCheckPath(uint32_t address_n_count,
const uint32_t *address_n) {
if (stellar_path_check(address_n_count, address_n)) {
return true;
}
if (config_getSafetyCheckLevel() == SafetyCheckLevel_Strict) {
fsm_sendFailure(FailureType_Failure_DataError, _("Forbidden key path"));
return false;
}
return fsm_layoutPathWarning();
}
void fsm_msgStellarGetAddress(const StellarGetAddress *msg) {
RESP_INIT(StellarAddress);
@ -24,10 +38,16 @@ void fsm_msgStellarGetAddress(const StellarGetAddress *msg) {
CHECK_PIN
if (!fsm_stellarCheckPath(msg->address_n_count, msg->address_n)) {
layoutHome();
return;
}
const HDNode *node = stellar_deriveNode(msg->address_n, msg->address_n_count);
if (!node) {
fsm_sendFailure(FailureType_Failure_ProcessError,
_("Failed to derive private key"));
layoutHome();
return;
}
@ -55,6 +75,11 @@ void fsm_msgStellarSignTx(const StellarSignTx *msg) {
CHECK_INITIALIZED
CHECK_PIN
if (!fsm_stellarCheckPath(msg->address_n_count, msg->address_n)) {
layoutHome();
return;
}
if (!stellar_signingInit(msg)) {
fsm_sendFailure(FailureType_Failure_ProcessError,
_("Failed to derive private key"));

13
legacy/firmware/stellar.c
View File

@ -2013,3 +2013,16 @@ void stellar_layoutTransactionDialog(const char *line1, const char *line2,
line1, line2, line3, line4, line5, stellar_activeTx.address_n,
stellar_activeTx.address_n_count, str_warning, false);
}
bool stellar_path_check(uint32_t address_n_count, const uint32_t *address_n) {
// SEP-0005 for non-UTXO-based currencies, defined by Stellar:
// https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0005.md
// m/44'/coin_type'/account'
bool valid = (address_n_count == 3);
valid = valid && (address_n[0] == (PATH_HARDENED | 44));
valid = valid && (address_n[1] == (PATH_HARDENED | 148) ||
address_n[1] == (PATH_HARDENED | 1));
valid = valid && (address_n[2] & PATH_HARDENED);
valid = valid && ((address_n[2] & PATH_UNHARDEN_MASK) <= PATH_MAX_ACCOUNT);
return valid;
}

2
legacy/firmware/stellar.h
View File

@ -117,4 +117,6 @@ bool stellar_validateAddress(const char *str_address);
bool stellar_getAddressBytes(const char *str_address, uint8_t *out_bytes);
uint16_t stellar_crc16(uint8_t *bytes, uint32_t length);
bool stellar_path_check(uint32_t address_n_count, const uint32_t *address_n);
#endif