arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-11-23 07:58:09 +00:00
Code Issues Releases Wiki Activity

stellar - minor cleanup and simplification of some boolean field checks

Browse Source
This commit is contained in:
ZuluCrypto 2018-04-28 12:39:55 -06:00
parent 49025aad2b
commit 2cf6414fa5
No known key found for this signature in database
GPG Key ID: 0D1266F87C28A2E1
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
trezorlib/stellar.py
View File

@ -71,7 +71,6 @@ def parse_transaction_bytes(tx_bytes):
tx = proto.StellarSignTx(
protocol_version=1
)
operations = []
unpacker = xdrlib.Unpacker(tx_bytes)
tx.source_account = _xdr_read_address(unpacker)
@ -79,8 +78,7 @@ def parse_transaction_bytes(tx_bytes):
tx.sequence_number = unpacker.unpack_uhyper()
# Timebounds is an optional field
has_timebounds = unpacker.unpack_bool()
if has_timebounds:
if unpacker.unpack_bool():
max_timebound = 2**32-1 # max unsigned 32-bit int (trezor does not support the full 64-bit time value)
tx.timebounds_start = unpacker.unpack_uhyper()
tx.timebounds_end = unpacker.unpack_uhyper()
@ -105,6 +103,7 @@ def parse_transaction_bytes(tx_bytes):
tx.num_operations = unpacker.unpack_uint()
operations = []
for i in range(tx.num_operations):
operations.append(_parse_operation_bytes(unpacker))
@ -117,8 +116,7 @@ def _parse_operation_bytes(unpacker):
# Check for and parse optional source account field
source_account = None
has_source_account = unpacker.unpack_bool()
if has_source_account:
if unpacker.unpack_bool():
source_account = unpacker.unpack_fopaque(32)
# Operation type (See OP_ constants)
@ -313,11 +311,11 @@ def _crc16_checksum(bytes):
polynomial = 0x1021
for byte in bytes:
for i in range(0, 8):
for i in range(8):
bit = ((byte >> (7 - i) & 1) == 1)
c15 = ((crc >> 15 & 1) == 1)
crc <<= 1
if c15 ^ bit:
crc ^= polynomial
return crc & 0xffff
return crc & 0xffff